Kaydet (Commit) 2fdafe62 authored tarafından Michael Weghorn's avatar Michael Weghorn

kde5backend.cxx: Fix inverted logic leading to invalid write

Only write to 'pFakeArgv[2]' when 'aDisplay' is NON-empty.

Otherwise, the 'pFakeArgv' array only has size 2 and the write
is invalid.

(Found by valgrind while looking at another issue.)

Change-Id: I58aff6d25c8647bc6ef346af8ac09b0b0fc030b8
Reviewed-on: https://gerrit.libreoffice.org/60476Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
üst 59887868
...@@ -159,7 +159,7 @@ void initQApp() ...@@ -159,7 +159,7 @@ void initQApp()
pFakeArgv[0] = strdup(getExecutable().getStr()); pFakeArgv[0] = strdup(getExecutable().getStr());
pFakeArgv[1] = strdup("--nocrashhandler"); pFakeArgv[1] = strdup("--nocrashhandler");
if (aDisplay.isEmpty()) if (!aDisplay.isEmpty())
pFakeArgv[2] = strdup(aDisplay.getStr()); pFakeArgv[2] = strdup(aDisplay.getStr());
char* session_manager = nullptr; char* session_manager = nullptr;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment