coverity warnings

Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1
Reviewed-on: https://gerrit.libreoffice.org/45023Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

basctl/source/inc/dlged.hxx

@@ -25,6 +25,7 @@
 #include <com/sun/star/datatransfer/DataFlavor.hpp>
 #include <com/sun/star/frame/XModel.hpp>
 #include <com/sun/star/util/XNumberFormatsSupplier.hpp>
+#include <o3tl/deleter.hxx>
 #include <svl/SfxBroadcaster.hxx>
 #include <svl/hint.hxx>
 #include <tools/gen.hxx>
@@ -118,7 +119,7 @@ private:
     css::uno::Sequence< css::datatransfer::DataFlavor >       m_ClipboardDataFlavors;
     css::uno::Sequence< css::datatransfer::DataFlavor >       m_ClipboardDataFlavorsResource;
     css::uno::Reference< css::util::XNumberFormatsSupplier >  m_xSupplier;
-    std::unique_ptr<DlgEdFactory> pObjFac; // never nullptr
+    std::unique_ptr<DlgEdFactory, o3tl::default_delete<DlgEdFactory>> pObjFac; // never nullptr
     vcl::Window&                    rWindow; // DialogWindow
     std::unique_ptr<DlgEdFunc>    pFunc;
     DialogWindowLayout& rLayout;

reportdesign/source/ui/inc/ReportWindow.hxx

@@ -22,6 +22,7 @@
 #include <com/sun/star/report/XSection.hpp>
 #include "ReportDefines.hxx"
 #include "StartMarker.hxx"
+#include <o3tl/deleter.hxx>
 #include <svtools/ruler.hxx>
 #include <svx/svdedtv.hxx>
 #include <sfx2/zoomitem.hxx>
@@ -49,9 +50,8 @@ namespace rptui
         VclPtr<ODesignView>            m_pView;
         VclPtr<OScrollWindowHelper>    m_pParent;
         VclPtr<OViewsWindow>           m_aViewsWindow;
-        ::rtl::Reference< comphelper::OPropertyChangeMultiplexer>   m_pReportListener;
-        ::std::unique_ptr<DlgEdFactory>
-                                m_pObjFac;
+        rtl::Reference< comphelper::OPropertyChangeMultiplexer>   m_pReportListener;
+        std::unique_ptr<DlgEdFactory, o3tl::default_delete<DlgEdFactory>>  m_pObjFac;
 
         void ImplInitSettings();
 

sc/source/ui/inc/gridwin.hxx

@@ -24,6 +24,7 @@
 #include "viewutil.hxx"
 #include "viewdata.hxx"
 #include "cbutton.hxx"
+#include <o3tl/deleter.hxx>
 #include <svx/sdr/overlay/overlayobject.hxx>
 #include <com/sun/star/sheet/DataPilotFieldOrientation.hpp>
 #include <basegfx/matrix/b2dhommatrix.hxx>
@@ -137,7 +138,7 @@ class ScGridWindow : public vcl::Window, public DropTargetHelper, public DragSou
     ScHSplitPos             eHWhich;
     ScVSplitPos             eVWhich;
 
-    std::unique_ptr<ScNoteMarker> mpNoteMarker;
+    std::unique_ptr<ScNoteMarker, o3tl::default_delete<ScNoteMarker>> mpNoteMarker;
 
     VclPtr<ScFilterListBox>          mpFilterBox;
     VclPtr<FloatingWindow>           mpFilterFloat;

sw/inc/pausethreadstarting.hxx

@@ -19,6 +19,8 @@
 #ifndef INCLUDED_SW_INC_PAUSETHREADSTARTING_HXX
 #define INCLUDED_SW_INC_PAUSETHREADSTARTING_HXX
 
+#include <sal/types.h>
+
 /** Helper class to pause starting of threads during existence of an instance
     of this class
 
@@ -31,7 +33,7 @@ class SwPauseThreadStarting
     public:
 
         SwPauseThreadStarting();
-        ~SwPauseThreadStarting();
+        ~SwPauseThreadStarting() COVERITY_NOEXCEPT_FALSE;
 
     private:
 

sw/source/core/crsr/crsrsh.cxx

@@ -1401,7 +1401,7 @@ class SwNotifyAccAboutInvalidTextSelections
             : mrCursorSh( _rCursorSh )
         {}
 
-        ~SwNotifyAccAboutInvalidTextSelections()
+        ~SwNotifyAccAboutInvalidTextSelections() COVERITY_NOEXCEPT_FALSE
         {
             mrCursorSh.InvalidateAccessibleParaTextSelection();
         }

sw/source/core/docnode/pausethreadstarting.cxx

@@ -37,7 +37,7 @@ SwPauseThreadStarting::SwPauseThreadStarting()
     }
 }
 
-SwPauseThreadStarting::~SwPauseThreadStarting()
+SwPauseThreadStarting::~SwPauseThreadStarting() COVERITY_NOEXCEPT_FALSE
 {
     if ( mbPausedThreadStarting )
     {

sw/source/core/docnode/retrieveinputstreamconsumer.cxx

@@ -34,7 +34,7 @@ SwAsyncRetrieveInputStreamThreadConsumer::SwAsyncRetrieveInputStreamThreadConsum
 {
 }
 
-SwAsyncRetrieveInputStreamThreadConsumer::~SwAsyncRetrieveInputStreamThreadConsumer()
+SwAsyncRetrieveInputStreamThreadConsumer::~SwAsyncRetrieveInputStreamThreadConsumer() COVERITY_NOEXCEPT_FALSE
 {
     SwThreadManager::GetThreadManager().RemoveThread( mnThreadID );
 }

sw/source/core/inc/retrieveinputstreamconsumer.hxx

@@ -36,7 +36,7 @@ class SwAsyncRetrieveInputStreamThreadConsumer
     public:
 
         SwAsyncRetrieveInputStreamThreadConsumer( SwGrfNode& rGrfNode );
-        ~SwAsyncRetrieveInputStreamThreadConsumer();
+        ~SwAsyncRetrieveInputStreamThreadConsumer() COVERITY_NOEXCEPT_FALSE;
 
         /** method to create thread
         */

sw/source/core/layout/anchoreddrawobject.cxx

@@ -46,7 +46,7 @@ class SwPosNotify
 
     public:
         explicit SwPosNotify( SwAnchoredDrawObject* _pAnchoredDrawObj );
-        ~SwPosNotify();
+        ~SwPosNotify() COVERITY_NOEXCEPT_FALSE;
         // #i32795#
         Point LastObjPos() const;
 };
@@ -59,7 +59,7 @@ SwPosNotify::SwPosNotify( SwAnchoredDrawObject* _pAnchoredDrawObj ) :
     mpOldPageFrame = mpAnchoredDrawObj->GetPageFrame();
 }
 
-SwPosNotify::~SwPosNotify()
+SwPosNotify::~SwPosNotify() COVERITY_NOEXCEPT_FALSE
 {
     if ( maOldObjRect != mpAnchoredDrawObj->GetObjRect() )
     {

sw/source/core/text/redlnitr.cxx

@@ -177,7 +177,7 @@ SwRedlineItr::SwRedlineItr( const SwTextNode& rTextNd, SwFont& rFnt,
     Seek (rFnt, 0, COMPLETE_STRING);
 }
 
-SwRedlineItr::~SwRedlineItr()
+SwRedlineItr::~SwRedlineItr() COVERITY_NOEXCEPT_FALSE
 {
     Clear( nullptr );
     delete pExt;

sw/source/core/text/redlnitr.hxx

@@ -89,7 +89,7 @@ public:
     SwRedlineItr( const SwTextNode& rTextNd, SwFont& rFnt, SwAttrHandler& rAH,
         sal_Int32 nRedlPos, bool bShw, const std::vector<ExtTextInputAttr> *pArr = nullptr,
         sal_Int32 nExtStart = COMPLETE_STRING );
-    ~SwRedlineItr();
+    ~SwRedlineItr() COVERITY_NOEXCEPT_FALSE;
     bool IsOn() const { return bOn || ( pExt && pExt->IsOn() ); }
     void Clear( SwFont* pFnt ) { if( bOn ) Clear_( pFnt ); }
     void ChangeTextAttr( SwFont* pFnt, SwTextAttr const &rHt, bool bChg );

sw/source/uibase/app/swdll.cxx

@@ -147,7 +147,7 @@ SwDLL::SwDLL()
     }
 }
 
-SwDLL::~SwDLL()
+SwDLL::~SwDLL() COVERITY_NOEXCEPT_FALSE
 {
     if (m_pAutoCorrCfg)
     {

sw/source/uibase/app/swdllimpl.hxx

@@ -26,7 +26,7 @@ public:
     static void RegisterControls();
 
     SwDLL();
-    ~SwDLL();
+    ~SwDLL() COVERITY_NOEXCEPT_FALSE;
 
     sw::Filters & getFilters();