Kaydet (Commit) 373affe5 authored tarafından Noel Grandin's avatar Noel Grandin Kaydeden (comit) Noel Grandin

java: remove some unnecessary interfaces

Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8
Reviewed-on: https://gerrit.libreoffice.org/13435Reviewed-by: 's avatarNoel Grandin <noelgrandin@gmail.com>
Tested-by: 's avatarNoel Grandin <noelgrandin@gmail.com>
üst 3dee6c74
...@@ -108,9 +108,6 @@ public class WeakBase_Test ...@@ -108,9 +108,6 @@ public class WeakBase_Test
} }
} }
interface Aint
{
}
class OtherClass extends WeakBase implements XBridgeSupplier2 class OtherClass extends WeakBase implements XBridgeSupplier2
{ {
...@@ -120,7 +117,7 @@ class OtherClass extends WeakBase implements XBridgeSupplier2 ...@@ -120,7 +117,7 @@ class OtherClass extends WeakBase implements XBridgeSupplier2
} }
} }
class SomeClass extends OtherClass implements Aint,XReference class SomeClass extends OtherClass implements XReference
{ {
public void dispose() public void dispose()
......
...@@ -100,7 +100,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ ...@@ -100,7 +100,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
qadevOOo/runner/graphical/GlobalLogWriter \ qadevOOo/runner/graphical/GlobalLogWriter \
qadevOOo/runner/graphical/GraphicalComparator \ qadevOOo/runner/graphical/GraphicalComparator \
qadevOOo/runner/graphical/HTMLResult \ qadevOOo/runner/graphical/HTMLResult \
qadevOOo/runner/graphical/IDocument \
qadevOOo/runner/graphical/ImageHelper \ qadevOOo/runner/graphical/ImageHelper \
qadevOOo/runner/graphical/IniFile \ qadevOOo/runner/graphical/IniFile \
qadevOOo/runner/graphical/IOffice \ qadevOOo/runner/graphical/IOffice \
...@@ -164,7 +163,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\ ...@@ -164,7 +163,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
qadevOOo/runner/org/openoffice/Runner \ qadevOOo/runner/org/openoffice/Runner \
qadevOOo/runner/org/openoffice/RunnerService \ qadevOOo/runner/org/openoffice/RunnerService \
qadevOOo/runner/share/ComplexTest \ qadevOOo/runner/share/ComplexTest \
qadevOOo/runner/share/CwsDataExchange \
qadevOOo/runner/share/DescEntry \ qadevOOo/runner/share/DescEntry \
qadevOOo/runner/share/DescGetter \ qadevOOo/runner/share/DescGetter \
qadevOOo/runner/share/LogWriter \ qadevOOo/runner/share/LogWriter \
......
...@@ -97,7 +97,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunnerLight,\ ...@@ -97,7 +97,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunnerLight,\
qadevOOo/runner/graphical/GlobalLogWriter \ qadevOOo/runner/graphical/GlobalLogWriter \
qadevOOo/runner/graphical/GraphicalComparator \ qadevOOo/runner/graphical/GraphicalComparator \
qadevOOo/runner/graphical/HTMLResult \ qadevOOo/runner/graphical/HTMLResult \
qadevOOo/runner/graphical/IDocument \
qadevOOo/runner/graphical/ImageHelper \ qadevOOo/runner/graphical/ImageHelper \
qadevOOo/runner/graphical/IniFile \ qadevOOo/runner/graphical/IniFile \
qadevOOo/runner/graphical/IOffice \ qadevOOo/runner/graphical/IOffice \
...@@ -161,7 +160,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunnerLight,\ ...@@ -161,7 +160,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunnerLight,\
qadevOOo/runner/org/openoffice/Runner \ qadevOOo/runner/org/openoffice/Runner \
qadevOOo/runner/org/openoffice/RunnerService \ qadevOOo/runner/org/openoffice/RunnerService \
qadevOOo/runner/share/ComplexTest \ qadevOOo/runner/share/ComplexTest \
qadevOOo/runner/share/CwsDataExchange \
qadevOOo/runner/share/DescEntry \ qadevOOo/runner/share/DescEntry \
qadevOOo/runner/share/DescGetter \ qadevOOo/runner/share/DescGetter \
qadevOOo/runner/share/LogWriter \ qadevOOo/runner/share/LogWriter \
......
...@@ -16,30 +16,17 @@ ...@@ -16,30 +16,17 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 . * the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/ */
/**
* Helper class to hold a Filename or a FileURL
* Something like File in Java,
* with some more extensions direct to ConvWatch and its name conventions
*
*
*/
package convwatch; package convwatch;
import helper.URLHelper; import helper.URLHelper;
import helper.StringHelper; import helper.StringHelper;
interface Filenamer /**
{ * Helper class to hold a Filename or a FileURL
String getSuffix(); * Something like File in Java,
String getFileURL(); * with some more extensions direct to ConvWatch and its name conventions
String getAbsoluteSystemFilename(); */
String getFilename(); abstract class FilenameHelper_impl
String getSystemPath();
}
abstract class FilenameHelper_impl implements Filenamer
{ {
private String fs; // file separator like '/' private String fs; // file separator like '/'
private String m_sPath; private String m_sPath;
......
...@@ -19,13 +19,18 @@ ...@@ -19,13 +19,18 @@
package graphical; package graphical;
import complexlib.ComplexTestCase; import complexlib.ComplexTestCase;
import java.io.File; import java.io.File;
import java.io.FileFilter; import java.io.FileFilter;
import java.util.ArrayList; import java.util.ArrayList;
abstract public class EnhancedComplexTestCase extends ComplexTestCase implements IDocument abstract public class EnhancedComplexTestCase extends ComplexTestCase
{ {
/**
* Call this for each document
*/
protected abstract void checkOneFile(String _sDocument, String _sResult, ParameterHelper _aParams) throws OfficeException;
private void callEntry(String _sEntry, ParameterHelper _aParam) private void callEntry(String _sEntry, ParameterHelper _aParam)
{ {
......
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
package graphical;
public interface IDocument
{
/**
* Call this for each document
*/
void checkOneFile(String _sDocument, String _sResult, ParameterHelper _aParams) throws OfficeException;
}
...@@ -22,16 +22,15 @@ import java.io.FileWriter; ...@@ -22,16 +22,15 @@ import java.io.FileWriter;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import lib.TestParameters; import lib.TestParameters;
import share.CwsDataExchange;
import share.LogWriter; import share.LogWriter;
import util.PropertyName; import util.PropertyName;
import util.utils; import util.utils;
/** /**
* Implementation of the interface CwsDataExchange * Exchange information to the EIS database
* @see share.CwsDataExchange *
*/ */
public class CwsDataExchangeImpl implements CwsDataExchange public class CwsDataExchangeImpl
{ {
private final TestParameters param; private final TestParameters param;
...@@ -47,6 +46,10 @@ public class CwsDataExchangeImpl implements CwsDataExchange ...@@ -47,6 +46,10 @@ public class CwsDataExchangeImpl implements CwsDataExchange
mDebug = param.getBool(PropertyName.DEBUG_IS_ACTIVE); mDebug = param.getBool(PropertyName.DEBUG_IS_ACTIVE);
} }
/**
* Returns all module names which are added to the specified childworkspace
* @return a String array of all added modules
*/
public ArrayList<String> getModules() public ArrayList<String> getModules()
{ {
// the cwstouched command send its version information to StdErr. // the cwstouched command send its version information to StdErr.
...@@ -97,6 +100,10 @@ public class CwsDataExchangeImpl implements CwsDataExchange ...@@ -97,6 +100,10 @@ public class CwsDataExchangeImpl implements CwsDataExchange
return moduleNames; return moduleNames;
} }
/**
* Set the test status of cws related UnoAPI tests to the EIS dabase
* @param status the status of the UnoAPI test
*/
public void setUnoApiCwsStatus(boolean status) public void setUnoApiCwsStatus(boolean status)
{ {
......
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
package share;
import java.util.ArrayList;
/**
* Exchange information to the EIS database
*
*/
public interface CwsDataExchange {
/**
* Retunrs all module names which are added to the specified childworkspace
* @return a String array of all added modules
*/
ArrayList<String> getModules();
/**
* Set the test status of cws related UnoAPI tests to the EIS dabase
* @param status the status of the UnoAPI test
*/
void setUnoApiCwsStatus(boolean status);
}
interface MessageInterface
{
void message (String text);
}
interface Print
{
void print (String text);
void println (String text);
}
...@@ -53,7 +53,6 @@ $(eval $(call gb_Jar_add_sourcefiles,commonwizards,\ ...@@ -53,7 +53,6 @@ $(eval $(call gb_Jar_add_sourcefiles,commonwizards,\
wizards/com/sun/star/wizards/common/NamedValueCollection \ wizards/com/sun/star/wizards/common/NamedValueCollection \
wizards/com/sun/star/wizards/common/ParaStyled \ wizards/com/sun/star/wizards/common/ParaStyled \
wizards/com/sun/star/wizards/common/PlaceholderTextElement \ wizards/com/sun/star/wizards/common/PlaceholderTextElement \
wizards/com/sun/star/wizards/common/TemplateElement \
wizards/com/sun/star/wizards/common/TextElement \ wizards/com/sun/star/wizards/common/TextElement \
wizards/com/sun/star/wizards/db/DBMetaData \ wizards/com/sun/star/wizards/db/DBMetaData \
wizards/com/sun/star/wizards/db/CommandMetaData \ wizards/com/sun/star/wizards/db/CommandMetaData \
...@@ -89,7 +88,6 @@ $(eval $(call gb_Jar_add_sourcefiles,commonwizards,\ ...@@ -89,7 +88,6 @@ $(eval $(call gb_Jar_add_sourcefiles,commonwizards,\
wizards/com/sun/star/wizards/ui/UnoDialog \ wizards/com/sun/star/wizards/ui/UnoDialog \
wizards/com/sun/star/wizards/ui/UnoDialog2 \ wizards/com/sun/star/wizards/ui/UnoDialog2 \
wizards/com/sun/star/wizards/ui/XFieldSelectionListener \ wizards/com/sun/star/wizards/ui/XFieldSelectionListener \
wizards/com/sun/star/wizards/ui/XCompletion \
wizards/com/sun/star/wizards/document/Control \ wizards/com/sun/star/wizards/document/Control \
wizards/com/sun/star/wizards/document/DatabaseControl \ wizards/com/sun/star/wizards/document/DatabaseControl \
wizards/com/sun/star/wizards/document/FormHandler \ wizards/com/sun/star/wizards/document/FormHandler \
......
...@@ -21,7 +21,7 @@ package com.sun.star.wizards.common; ...@@ -21,7 +21,7 @@ package com.sun.star.wizards.common;
import com.sun.star.uno.UnoRuntime; import com.sun.star.uno.UnoRuntime;
import com.sun.star.text.*; import com.sun.star.text.*;
class ParaStyled implements TemplateElement class ParaStyled
{ {
private String paraStyle; private String paraStyle;
......
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
package com.sun.star.wizards.common;
interface TemplateElement
{
}
...@@ -125,9 +125,6 @@ public class TableWizard extends DatabaseObjectWizard implements XTextListener ...@@ -125,9 +125,6 @@ public class TableWizard extends DatabaseObjectWizard implements XTextListener
} }
/* (non-Javadoc)
* @see com.sun.star.wizards.ui.XCompletion#iscompleted(int)
*/
public boolean iscompleted(int _ndialogpage) public boolean iscompleted(int _ndialogpage)
{ {
switch (_ndialogpage) switch (_ndialogpage)
...@@ -149,9 +146,6 @@ public class TableWizard extends DatabaseObjectWizard implements XTextListener ...@@ -149,9 +146,6 @@ public class TableWizard extends DatabaseObjectWizard implements XTextListener
} }
/* (non-Javadoc)
* @see com.sun.star.wizards.ui.XCompletion#setcompleted(int, boolean)
*/
public void setcompleted(int _ndialogpage, boolean _biscompleted) public void setcompleted(int _ndialogpage, boolean _biscompleted)
{ {
boolean bScenarioiscompleted = _biscompleted; boolean bScenarioiscompleted = _biscompleted;
......
...@@ -44,7 +44,7 @@ import com.sun.star.wizards.ui.event.XActionListenerAdapter; ...@@ -44,7 +44,7 @@ import com.sun.star.wizards.ui.event.XActionListenerAdapter;
import com.sun.star.wizards.ui.event.XItemListenerAdapter; import com.sun.star.wizards.ui.event.XItemListenerAdapter;
import com.sun.star.wizards.ui.event.XWindowListenerAdapter; import com.sun.star.wizards.ui.event.XWindowListenerAdapter;
public abstract class WizardDialog extends UnoDialog2 implements VetoableChangeListener, XTerminateListener, XCompletion public abstract class WizardDialog extends UnoDialog2 implements VetoableChangeListener, XTerminateListener
{ {
private static final int iButtonWidth = 50; private static final int iButtonWidth = 50;
...@@ -359,28 +359,6 @@ public abstract class WizardDialog extends UnoDialog2 implements VetoableChangeL ...@@ -359,28 +359,6 @@ public abstract class WizardDialog extends UnoDialog2 implements VetoableChangeL
} }
/* (non-Javadoc)
* @see com.sun.star.wizards.ui.XCompletion#iscompleted(int)
*/
public boolean iscompleted(int _ndialogpage)
{
return false;
}
/* (non-Javadoc)
* @see com.sun.star.wizards.ui.XCompletion#setcompleted(int, boolean)
*/
public void setcompleted(int _ndialogpage, boolean _biscompleted)
{
}
/* (non-Javadoc)
* @see com.sun.star.wizards.ui.XCompletion#setmodified(int, java.lang.Object, java.lang.Object)
*/
public void setmodified(int _ndialogpage, Object ooldValue, Object onewValue)
{
}
public void drawNaviBar() public void drawNaviBar()
{ {
......
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
package com.sun.star.wizards.ui;
public interface XCompletion
{
void setcompleted(int _ndialogpage, boolean _biscompleted);
boolean iscompleted(int _ndialogpage);
}
...@@ -114,10 +114,6 @@ public abstract class DataAware { ...@@ -114,10 +114,6 @@ public abstract class DataAware {
enableControls(ui); enableControls(ui);
} }
public interface Listener {
void eventPerformed(Object event);
}
/** /**
* compares the two given objects. * compares the two given objects.
* This method is null safe and returns true also if both are null... * This method is null safe and returns true also if both are null...
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment