Kaydet (Commit) 3ae3f098 authored tarafından Kohei Yoshida's avatar Kohei Yoshida

Fixed potential memory leak & UniString removal.

üst 32502a98
...@@ -1037,11 +1037,14 @@ SvXMLImportContext *ScXMLDataPilotFieldContext::CreateChildContext( sal_uInt16 n ...@@ -1037,11 +1037,14 @@ SvXMLImportContext *ScXMLDataPilotFieldContext::CreateChildContext( sal_uInt16 n
void ScXMLDataPilotFieldContext::AddMember(ScDPSaveMember* pMember) void ScXMLDataPilotFieldContext::AddMember(ScDPSaveMember* pMember)
{ {
if (pDim) if (pDim)
{
pDim->AddMember(pMember); pDim->AddMember(pMember);
if (!pMember->GetIsVisible())
if (!pMember->GetIsVisible()) // This member is hidden.
// This member is hidden. mbHasHiddenMember = true;
mbHasHiddenMember = true; }
else
delete pMember;
} }
void ScXMLDataPilotFieldContext::SetSubTotalName(const OUString& rName) void ScXMLDataPilotFieldContext::SetSubTotalName(const OUString& rName)
...@@ -1636,7 +1639,7 @@ void ScXMLDataPilotMemberContext::EndElement() ...@@ -1636,7 +1639,7 @@ void ScXMLDataPilotMemberContext::EndElement()
{ {
if (bHasName) // #i53407# don't check sName, empty name is allowed if (bHasName) // #i53407# don't check sName, empty name is allowed
{ {
ScDPSaveMember* pMember = new ScDPSaveMember(String(sName)); ScDPSaveMember* pMember = new ScDPSaveMember(sName);
if (!maDisplayName.isEmpty()) if (!maDisplayName.isEmpty())
pMember->SetLayoutName(maDisplayName); pMember->SetLayoutName(maDisplayName);
pMember->SetIsVisible(bDisplay); pMember->SetIsVisible(bDisplay);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment