installer: Inline @installer::globals::environmentvariables

Change-Id: I9aab3ec39b833dac242b9ede21ac3f2e5eb78200

solenv/bin/modules/installer/control.pm

@@ -271,16 +271,22 @@ sub check_makecab_version
 sub check_system_environment
 {
     my %variables = ();
-    my $key;
     my $error = 0;
 
-    foreach $key ( @installer::globals::environmentvariables )
+    my @environmentvariables = qw(
+        SOLARVERSION
+        GUI
+        WORK_STAMP
+        OUTPATH
+        LOCAL_OUT
+        LOCAL_COMMON_OUT
+    );
+
+    for my $key ( @environmentvariables )
     {
-        my $value = "";
-        if ( $ENV{$key} ) { $value = $ENV{$key}; }
-        $variables{$key} = $value;
+        $variables{$key} = $ENV{$key} || "";
 
-        if ( $value eq "" )
+        if ( $variables{$key} eq "" )
         {
             installer::logger::print_error( "$key not set in environment\n" );
             $error = 1;

solenv/bin/modules/installer/globals.pm

@@ -263,7 +263,6 @@ BEGIN
     @solarispatchscripts = ("checkinstall", "copyright", "patch_checkinstall", "patch_postinstall", "postinstall", "preinstall", "i.none");
     @solarispatchscriptsforextensions = ("checkinstall", "copyright", "patch_checkinstall", "patch_postinstall_extensions", "postinstall_extensions", "preinstall", "i.none");
     @solarispatchfiles = (".diPatch", "patchinfo");
-    @environmentvariables = ( "SOLARVERSION", "GUI", "WORK_STAMP", "OUTPATH", "LOCAL_OUT", "LOCAL_COMMON_OUT" );
     @packagelistitems = ("module", "solarispackagename", "packagename", "copyright", "vendor", "description" );
     @languagepackfeature =();
     @helppackfeature =();