make this a little less confusing

... and change to a friendlier red for invalid patterns.

Change-Id: I19488abd496b144439d7918dc31cfd3f5f4fef92

cui/source/options/optgdlg.cxx

@@ -1762,16 +1762,12 @@ IMPL_LINK( OfaLanguagesTabPage, DatePatternsHdl, Edit*, pEd )
     }
     else
     {
-        // color to use as background for an invalid pattern
-        #define INVALID_PATTERN_BACKGROUND_COLOR ::Color(0xff6563)
 #if 0
-        // color to use as foreground for an invalid pattern
-        #define INVALID_PATTERN_FOREGROUND_COLOR Color(COL_WHITE)
-        //! Gives white on white!?!
-        pEd->SetControlBackground( INVALID_PATTERN_BACKGROUND_COLOR);
-        pEd->SetControlForeground( INVALID_PATTERN_FOREGROUND_COLOR);
+        //! Gives white on white!?! instead of white on reddish.
+        pEd->SetControlBackground( ::Color( RGB_COLORDATA( 0xff, 0x65, 0x63)));
+        pEd->SetControlForeground( ::Color( COL_WHITE));
 #else
-        pEd->SetControlForeground( INVALID_PATTERN_BACKGROUND_COLOR);
+        pEd->SetControlForeground( ::Color( RGB_COLORDATA( 0xf0, 0, 0)));
 #endif
     }
     return 0;