loplugin:stringconstant

Change-Id: I95765e9c26e393a838ee0c617fde415e6c50e884

ucb/source/ucp/webdav/DateTimeHelper.cxx

@@ -127,29 +127,29 @@ sal_Int32 DateTimeHelper::convertDayToInt (const OUString& day)
 
 sal_Int32 DateTimeHelper::convertMonthToInt (const OUString& month)
 {
-    if (month.equalsAscii("Jan"))
+    if (month == "Jan")
         return 1;
-    else if (month.equalsAscii("Feb"))
+    else if (month == "Feb")
         return 2;
-    else if (month.equalsAscii("Mar"))
+    else if (month == "Mar")
         return 3;
-    else if (month.equalsAscii("Apr"))
+    else if (month == "Apr")
         return 4;
-    else if (month.equalsAscii("May"))
+    else if (month == "May")
         return 5;
-    else if (month.equalsAscii("Jun"))
+    else if (month == "Jun")
         return 6;
-    else if (month.equalsAscii("Jul"))
+    else if (month == "Jul")
         return 7;
-    else if (month.equalsAscii("Aug"))
+    else if (month == "Aug")
         return 8;
-    else if (month.equalsAscii("Sep"))
+    else if (month == "Sep")
         return 9;
-    else if (month.equalsAscii("Oct"))
+    else if (month == "Oct")
         return 10;
-    else if (month.equalsAscii("Nov"))
+    else if (month == "Nov")
         return 11;
-    else if (month.equalsAscii("Dec"))
+    else if (month == "Dec")
         return 12;
     else
         return 0;

ucb/source/ucp/webdav/SerfUri.cxx

@@ -202,7 +202,7 @@ OUString SerfUri::GetPathBaseNameUnescaped () const
 void SerfUri::AppendPath (const OUString& rPath)
 {
     if (mPath.lastIndexOf ('/') != mPath.getLength () - 1)
-        mPath += OUString("/");
+        mPath += "/";
 
     mPath += rPath;
     calculateURI ();

ucb/source/ucp/webdav/webdavcontent.cxx

@@ -1134,7 +1134,7 @@ Content::queryCreatableContentsInfo()
     uno::Sequence< ucb::ContentInfo > aSeq( 2 );
 
     // document.
-    aSeq.getArray()[ 0 ].Type = OUString( WEBDAV_CONTENT_TYPE );
+    aSeq.getArray()[ 0 ].Type = WEBDAV_CONTENT_TYPE;
     aSeq.getArray()[ 0 ].Attributes
         = ucb::ContentInfoAttribute::INSERT_WITH_INPUTSTREAM
           | ucb::ContentInfoAttribute::KIND_DOCUMENT;
@@ -1148,7 +1148,7 @@ Content::queryCreatableContentsInfo()
     aSeq.getArray()[ 0 ].Properties = aDocProps;
 
     // folder.
-    aSeq.getArray()[ 1 ].Type = OUString( WEBDAV_COLLECTION_TYPE );
+    aSeq.getArray()[ 1 ].Type = WEBDAV_COLLECTION_TYPE;
     aSeq.getArray()[ 1 ].Attributes
         = ucb::ContentInfoAttribute::KIND_FOLDER;
 

ucb/source/ucp/webdav/webdavprovider.cxx

@@ -94,7 +94,7 @@ XTYPEPROVIDER_IMPL_3( ContentProvider,
 
 XSERVICEINFO_IMPL_1_CTX( ContentProvider,
                      OUString( "com.sun.star.comp.WebDAVContentProvider" ),
-                     OUString( WEBDAV_CONTENT_PROVIDER_SERVICE_NAME ) );
+                     WEBDAV_CONTENT_PROVIDER_SERVICE_NAME );
 
 
 

ucb/source/ucp/webdav/webdavresponseparser.cxx

@@ -230,7 +230,7 @@ namespace
     void WebDAVContext::splitName(const OUString& rSource)
     {
         const sal_Int32 nLen(rSource.getLength());
-        maNamespace = "";
+        maNamespace.clear();
         maName = rSource;
 
         if(nLen)
@@ -457,7 +457,8 @@ namespace
                             case WebDAVName_response:
                             {
                                 // response start, reset Href and status and maResponseProperties
-                                maHref = maStatus = "";
+                                maHref.clear();
+                                maStatus.clear();
 
                                 if(isCollectingProperties())
                                 {
@@ -807,7 +808,7 @@ namespace
                 if(aNew.getLength())
                 {
                     // add one char when appending (see html1.1 spec)
-                    aNew += OUString(' ');
+                    aNew += " ";
                 }
 
                 aNew += aTrimmedChars;