sdext: fix loplugin warnings

Change-Id: I4bca280b352f1df40fe75658e418f2e0cb2430e8

sdext/source/minimizer/optimizerdialog.cxx

@@ -158,7 +158,6 @@ void OptimizerDialog::InsertRoadmapItem( const sal_Int32 nIndex, const sal_Bool
 void OptimizerDialog::UpdateConfiguration()
 {
     sal_Int16   nInt16 = 0;
-    OUString    aString;
     Any         aAny;
 
     Sequence< sal_Int16 > aSelectedItems;

sdext/source/minimizer/pppoptimizerdialog.cxx

@@ -147,7 +147,7 @@ void SAL_CALL PPPOptimizerDialog::dispatch( const URL& rURL,
                     sBuf.append( rtl::OUString("KB to ") );
                     sBuf.append( rtl::OUString::valueOf( nFileSizeDest >> 10 ) );
                     sBuf.append( rtl::OUString("KB.") );
-                    OUString sResult( sBuf.makeStringAndClear() );
+                    sBuf.makeStringAndClear();
 //                  mpOptimizerDialog->showMessageBox( sResult, sResult, sal_False );
                 }
                 delete mpOptimizerDialog, mpOptimizerDialog = NULL;

sdext/source/pdfimport/tree/drawtreevisiting.cxx

@@ -1014,7 +1014,6 @@ void DrawXmlFinalizer::visit( PageElement& elem, const std::list< Element* >::co
     // get styles for paragraphs
     PropertyMap aPageProps;
     PropertyMap aPageLayoutProps;
-    rtl::OUStringBuffer aBuf( 64 );
     aPageLayoutProps[ "fo:margin-top" ]     =  unitMMString( top_margin );
     aPageLayoutProps[ "fo:margin-bottom" ]  =  unitMMString( bottom_margin );
     aPageLayoutProps[ "fo:margin-left" ]    =  unitMMString( left_margin );
@@ -1040,9 +1039,6 @@ void DrawXmlFinalizer::visit( PageElement& elem, const std::list< Element* >::co
 
     elem.StyleId = m_rStyleContainer.impl_getStyleId( aMPStyle,false );
 
-
-    rtl::OUString aMasterPageName = m_rStyleContainer.getStyleName( elem.StyleId );
-
     // create styles for children
     elem.applyToChildren(*this);
 }

sdext/source/pdfimport/tree/pdfiprocessor.cxx

@@ -466,8 +466,6 @@ GraphicsContext& PDFIProcessor::getTransformGlyphContext( CharGlyph& rGlyph )
     geometry::RealRectangle2D   rRect = rGlyph.getRect();
     geometry::Matrix2D          rFontMatrix = rGlyph.getFontMatrix();
 
-    rtl::OUString tempStr( 32 );
-
     basegfx::B2DHomMatrix aFontMatrix;
     basegfx::unotools::homMatrixFromMatrix(
         aFontMatrix,

sdext/source/pdfimport/tree/writertreevisiting.cxx

@@ -1145,7 +1145,6 @@ void WriterXmlFinalizer::visit( PageElement& elem, const std::list< Element* >::
     // get styles for paragraphs
     PropertyMap aPageProps;
     PropertyMap aPageLayoutProps;
-    rtl::OUStringBuffer aBuf( 64 );
     aPageLayoutProps[ "fo:page-width" ]     = unitMMString( page_width );
     aPageLayoutProps[ "fo:page-height" ]    = unitMMString( page_height );
     aPageLayoutProps[ "style:print-orientation" ]

sdext/source/pdfimport/wrapper/wrapper.cxx

@@ -484,7 +484,7 @@ int Parser::parseFontRemoveSuffix( const sal_Unicode* pCopy, const char* s, sal_
     for (int i = 0; i < l; i++)
         if ( pCopy[nLen - l + i] != s[i] )
             return 0;
-        nLen -= l;
+    nLen -= l;
     return l;
 }
 

sdext/source/presenter/PresenterSlideShowView.cxx

@@ -487,7 +487,7 @@ void SAL_CALL PresenterSlideShowView::setMouseCursor(::sal_Int16 nPointerShape)
 awt::Rectangle SAL_CALL PresenterSlideShowView::getCanvasArea(  ) throw (RuntimeException)
 {
     if( mxViewWindow.is() && mxTopPane.is() )
-    return mxPresenterHelper->getWindowExtentsRelative( mxViewWindow, mxTopPane->getWindow() );
+        return mxPresenterHelper->getWindowExtentsRelative( mxViewWindow, mxTopPane->getWindow() );
 
     awt::Rectangle aRectangle;