OModule::onFirstClient is unused

also move the MutexGuard in revokeClient. No need to hold it while doing
an osl_atomic_increment. Save it until we actually need to call
onLastClient.

Change-Id: Ia87f24b66b0430604a2fe717c95223ff1f5ece6d
Reviewed-on: https://gerrit.libreoffice.org/20919Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

comphelper/source/misc/componentmodule.cxx

@@ -75,22 +75,17 @@ namespace comphelper
 
     void OModule::registerClient( OModule::ClientAccess )
     {
-        ::osl::MutexGuard aGuard(m_aMutex);
-        if ( 1 == osl_atomic_increment( &m_nClients ) )
-            onFirstClient();
+        osl_atomic_increment( &m_nClients );
     }
 
 
     void OModule::revokeClient( OModule::ClientAccess )
     {
-        ::osl::MutexGuard aGuard(m_aMutex);
         if ( 0 == osl_atomic_decrement( &m_nClients ) )
+        {
+            ::osl::MutexGuard aGuard(m_aMutex);
             onLastClient();
-    }
-
-
-    void OModule::onFirstClient()
-    {
+        }
     }
 
 

include/comphelper/componentmodule.hxx

@@ -142,11 +142,6 @@ namespace comphelper
         void revokeClient( ClientAccess );
 
     protected:
-        /** called when the first client has been registered
-            @precond
-                <member>m_aMutex</member> is locked
-        */
-        virtual void onFirstClient();
 
         /** called when the last client has been revoked
             @precond

include/unotools/componentresmodule.hxx

@@ -57,7 +57,6 @@ namespace utl
 
     protected:
         // OModule overridables
-        virtual void onFirstClient() override;
         virtual void onLastClient() override;
     };
 

unotools/source/misc/componentresmodule.cxx

@@ -105,11 +105,6 @@ namespace utl
         return m_pImpl->getResManager();
     }
 
-    void OComponentResourceModule::onFirstClient()
-    {
-        BaseClass::onFirstClient();
-    }
-
     void OComponentResourceModule::onLastClient()
     {
         m_pImpl->freeResManager();