loplugin:redundantcast: sc

(after a to-be-committed improved loplugin:cstylecast would have rewritten the
C-style casts into static_casts)

Change-Id: Ia9e3cf3d5483d1d77227db67dbfa304fa6060398

sc/source/core/data/dpoutput.cxx

@@ -359,7 +359,7 @@ void lcl_FillNumberFormats( std::unique_ptr<sal_uInt32[]>& rFormats, long& rCoun
         if ( xDimProp.is() && xDimName.is() )
         {
             sheet::DataPilotFieldOrientation eDimOrient =
-                (sheet::DataPilotFieldOrientation) ScUnoHelpFunctions::GetEnumProperty(
+                ScUnoHelpFunctions::GetEnumProperty(
                     xDimProp, SC_UNO_DP_ORIENTATION,
                     sheet::DataPilotFieldOrientation_HIDDEN );
             if ( eDimOrient == sheet::DataPilotFieldOrientation_DATA )
@@ -422,7 +422,7 @@ sal_uInt32 lcl_GetFirstNumberFormat( const uno::Reference<container::XIndexAcces
         if ( xDimProp.is() )
         {
             sheet::DataPilotFieldOrientation eDimOrient =
-                (sheet::DataPilotFieldOrientation) ScUnoHelpFunctions::GetEnumProperty(
+                ScUnoHelpFunctions::GetEnumProperty(
                     xDimProp, SC_UNO_DP_ORIENTATION,
                     sheet::DataPilotFieldOrientation_HIDDEN );
             if ( eDimOrient == sheet::DataPilotFieldOrientation_DATA )
@@ -543,7 +543,7 @@ ScDPOutput::ScDPOutput( ScDocument* pD, const uno::Reference<sheet::XDimensionsS
             if ( xDimProp.is() && xDimSupp.is() )
             {
                 sheet::DataPilotFieldOrientation eDimOrient =
-                    (sheet::DataPilotFieldOrientation) ScUnoHelpFunctions::GetEnumProperty(
+                    ScUnoHelpFunctions::GetEnumProperty(
                         xDimProp, SC_UNO_DP_ORIENTATION,
                         sheet::DataPilotFieldOrientation_HIDDEN );
                 long nDimPos = ScUnoHelpFunctions::GetLongProperty( xDimProp,
@@ -1254,7 +1254,7 @@ void lcl_GetTableVars( sal_Int32& rGrandTotalCols, sal_Int32& rGrandTotalRows, s
             if ( xDimProp.is() )
             {
                 sheet::DataPilotFieldOrientation eDimOrient =
-                    (sheet::DataPilotFieldOrientation) ScUnoHelpFunctions::GetEnumProperty(
+                    ScUnoHelpFunctions::GetEnumProperty(
                         xDimProp, SC_UNO_DP_ORIENTATION,
                         sheet::DataPilotFieldOrientation_HIDDEN );
                 if ( ScUnoHelpFunctions::GetBoolProperty( xDimProp,

sc/source/core/data/dpsave.cxx

@@ -530,7 +530,7 @@ void ScDPSaveDimension::WriteToSource( const uno::Reference<uno::XInterface>& xD
     {
         // exceptions are caught at ScDPSaveData::WriteToSource
 
-        sheet::DataPilotFieldOrientation eOrient = (sheet::DataPilotFieldOrientation)nOrientation;
+        sheet::DataPilotFieldOrientation eOrient = nOrientation;
         xDimProp->setPropertyValue( SC_UNO_DP_ORIENTATION, uno::Any(eOrient) );
 
         sal_Int16 eFunc = static_cast<sal_Int16>(nFunction);

sc/source/filter/xml/XMLExportDataPilot.cxx

@@ -685,7 +685,7 @@ void ScXMLExportDataPilot::WriteDimension(const ScDPSaveDimension* pDim, const S
     if (pDim->IsDataLayout())
         rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_IS_DATA_LAYOUT_FIELD, XML_TRUE);
     OUString sValueStr;
-    sheet::DataPilotFieldOrientation eOrientation = (sheet::DataPilotFieldOrientation) pDim->GetOrientation();
+    sheet::DataPilotFieldOrientation eOrientation = pDim->GetOrientation();
     ScXMLConverter::GetStringFromOrientation( sValueStr,
          eOrientation);
     if( !sValueStr.isEmpty() )