check that ODK headers compile with C++03

Change-Id: Ief191a5bbbdca45aaaa8ae5bcc395124ed189796

odk/CppunitTest_odk_checkapi.mk

@@ -27,6 +27,7 @@ $(eval $(call gb_CppunitTest_disable_compiler_plugins,odk_checkapi))
 
 $(eval $(call gb_CppunitTest_add_cxxflags,odk_checkapi,\
 	$(gb_CXXFLAGS_Wundef) \
+	$(gb_CXX03FLAGS) \
 ))
 
 $(eval $(call gb_CppunitTest_use_libraries,odk_checkapi,\

odk/qa/checkapi/checkapi.cxx

@@ -20,6 +20,12 @@
 #error Build system problem, RTL_USING using should not be set here.
 #endif
 
+// Additionally, check that public API headers build also with C++03.
+
+//#if __cplusplus >= 201103L
+//#error Build system problem, C++03 should be used here.
+//#endif
+
 // This module contains no tests, this is for the build system.
 #include <cppunit/plugin/TestPlugIn.h>
 

solenv/gbuild/platform/com_GCC_defs.mk

@@ -97,6 +97,14 @@ endif
 
 gb_CFLAGS_WERROR := $(if $(ENABLE_WERROR),-Werror)
 
+# This is the default in non-C++11 mode
+ifeq ($(COM_GCC_IS_CLANG),TRUE)
+# doesn't know gnu++03 and this seems to be the same anyway
+gb_CXX03FLAGS := -std=gnu++98 -Werror=c++11-extensions -Wno-c++11-long-long
+else
+gb_CXX03FLAGS := -std=gnu++03 -pedantic-errors -Wno-long-long
+endif
+
 ifeq ($(ENABLE_LTO),TRUE)
 ifeq ($(COM_GCC_IS_CLANG),TRUE)
 gb_LTOFLAGS := -flto

solenv/gbuild/platform/com_MSC_defs.mk

@@ -247,6 +247,9 @@ gb_STDLIBS := \
 
 gb_CFLAGS_WERROR := $(if $(ENABLE_WERROR),-WX)
 
+# there does not seem to be a way to force C++03 with MSVC
+gb_CXX03FLAGS :=
+
 gb_LinkTarget_EXCEPTIONFLAGS := \
 	-DEXCEPTIONS_ON \
 	-EHa \