Kaydet (Commit) 42d27ed5 authored tarafından Tamás Zolnai's avatar Tamás Zolnai Kaydeden (comit) Andras Timar

tdf#122765: Legend interferes with pie chart after pptx import, second part

Revert of:
2903c5f5

Reverting this commit does not lead to the original bug
to come back, so we can revert it without a problem.

Change-Id: I244a6b9451c47e1094db8a77c71b6696e0c464cc
Reviewed-on: https://gerrit.libreoffice.org/73139Reviewed-by: 's avatarTamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: 's avatarTamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 63d17d01)
Reviewed-on: https://gerrit.libreoffice.org/73159
Tested-by: Jenkins
Reviewed-by: 's avatarAndras Timar <andras.timar@collabora.com>
üst 7ea8112e
...@@ -1499,7 +1499,6 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D ...@@ -1499,7 +1499,6 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D
uno::Reference< drawing::XShapes > xSeriesTargetInFrontOfAxis; uno::Reference< drawing::XShapes > xSeriesTargetInFrontOfAxis;
uno::Reference< drawing::XShapes > xSeriesTargetBehindAxis; uno::Reference< drawing::XShapes > xSeriesTargetBehindAxis;
VDiagram aVDiagram(xDiagram, aPreferredAspectRatio, nDimensionCount); VDiagram aVDiagram(xDiagram, aPreferredAspectRatio, nDimensionCount);
bool bIsPieOrDonut = lcl_IsPieOrDonut(xDiagram);
{//create diagram {//create diagram
aVDiagram.init(rParam.mxDiagramWithAxesShapes, m_xShapeFactory); aVDiagram.init(rParam.mxDiagramWithAxesShapes, m_xShapeFactory);
aVDiagram.createShapes( aVDiagram.createShapes(
...@@ -1508,7 +1507,7 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D ...@@ -1508,7 +1507,7 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D
xSeriesTargetInFrontOfAxis = aVDiagram.getCoordinateRegion(); xSeriesTargetInFrontOfAxis = aVDiagram.getCoordinateRegion();
// It is preferable to use full size than minimum for pie charts // It is preferable to use full size than minimum for pie charts
if (!bIsPieOrDonut && !rParam.mbUseFixedInnerSize) if (!rParam.mbUseFixedInnerSize)
aVDiagram.reduceToMimimumSize(); aVDiagram.reduceToMimimumSize();
} }
...@@ -1536,6 +1535,7 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D ...@@ -1536,6 +1535,7 @@ awt::Rectangle ChartView::impl_createDiagramAndContent( const CreateShapeParam2D
//use first coosys only so far; todo: calculate for more than one coosys if we have more in future //use first coosys only so far; todo: calculate for more than one coosys if we have more in future
//todo: this is just a workaround at the moment for pie and donut labels //todo: this is just a workaround at the moment for pie and donut labels
bool bIsPieOrDonut = lcl_IsPieOrDonut(xDiagram);
if( !bIsPieOrDonut && (!rVCooSysList.empty()) ) if( !bIsPieOrDonut && (!rVCooSysList.empty()) )
{ {
VCoordinateSystem* pVCooSys = rVCooSysList[0].get(); VCoordinateSystem* pVCooSys = rVCooSysList[0].get();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment