Kaydet (Commit) 45048222 authored tarafından Gabor Kelemen's avatar Gabor Kelemen Kaydeden (comit) Miklos Vajna

find-unneeded-includes: stop proposing internal libstdc++ headers

They wouldn't really compile anyways and only cause unnecessary
blacklist entries.
Some '- memory' entries can already be removed from the blacklists.

Change-Id: Iab53d5a57121f61abe935e712dc23a55390235bf
Reviewed-on: https://gerrit.libreoffice.org/56979
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
üst 2f324e53
...@@ -53,6 +53,15 @@ def ignoreRemoval(include, toAdd, absFileName, moduleRules): ...@@ -53,6 +53,15 @@ def ignoreRemoval(include, toAdd, absFileName, moduleRules):
if include == k and v in toAdd: if include == k and v in toAdd:
return True return True
# Avoid proposing to use libstdc++ internal headers.
bits = {
"exception": "bits/exception.h",
"memory": "bits/shared_ptr.h",
}
for k, v in bits.items():
if include == k and v in toAdd:
return True
# Follow boost documentation. # Follow boost documentation.
if include == "boost/optional.hpp" and "boost/optional/optional.hpp" in toAdd: if include == "boost/optional.hpp" and "boost/optional/optional.hpp" in toAdd:
return True return True
......
...@@ -38,9 +38,6 @@ blacklist: ...@@ -38,9 +38,6 @@ blacklist:
- com/sun/star/lang/XUnoTunnel.hpp - com/sun/star/lang/XUnoTunnel.hpp
- com/sun/star/qa/XDumper.hpp - com/sun/star/qa/XDumper.hpp
- com/sun/star/util/XModifyListener.hpp - com/sun/star/util/XModifyListener.hpp
chart2/source/inc/chartview/ExplicitValueProvider.hxx:
# base class has to be a complete type
- memory
chart2/source/inc/AxisHelper.hxx: chart2/source/inc/AxisHelper.hxx:
# base class has to be a complete type # base class has to be a complete type
- com/sun/star/chart2/ScaleData.hpp - com/sun/star/chart2/ScaleData.hpp
......
...@@ -38,9 +38,6 @@ blacklist: ...@@ -38,9 +38,6 @@ blacklist:
sc/inc/autoform.hxx: sc/inc/autoform.hxx:
# contains macro definitions # contains macro definitions
- scitems.hxx - scitems.hxx
sc/inc/calcconfig.hxx:
# needed for std::shared_ptr
- memory
sc/inc/chartuno.hxx: sc/inc/chartuno.hxx:
# base class has to be a complete type # base class has to be a complete type
- com/sun/star/container/XEnumerationAccess.hpp - com/sun/star/container/XEnumerationAccess.hpp
...@@ -253,9 +250,6 @@ blacklist: ...@@ -253,9 +250,6 @@ blacklist:
sc/inc/scmatrix.hxx: sc/inc/scmatrix.hxx:
# base class has to be a complete type # base class has to be a complete type
- svl/sharedstringpool.hxx - svl/sharedstringpool.hxx
sc/inc/simplerangelist.hxx:
# base class has to be a complete type
- memory
sc/inc/spellcheckcontext.hxx: sc/inc/spellcheckcontext.hxx:
# base class has to be a complete type # base class has to be a complete type
- editeng/misspellrange.hxx - editeng/misspellrange.hxx
...@@ -298,9 +292,6 @@ blacklist: ...@@ -298,9 +292,6 @@ blacklist:
- com/sun/star/lang/XServiceInfo.hpp - com/sun/star/lang/XServiceInfo.hpp
- com/sun/star/lang/XUnoTunnel.hpp - com/sun/star/lang/XUnoTunnel.hpp
- com/sun/star/text/XTextFieldsSupplier.hpp - com/sun/star/text/XTextFieldsSupplier.hpp
sc/inc/token.hxx:
# needed for std::shared_ptr
- memory
sc/inc/tokenuno.hxx: sc/inc/tokenuno.hxx:
# base class has to be a complete type # base class has to be a complete type
- com/sun/star/beans/XPropertySet.hpp - com/sun/star/beans/XPropertySet.hpp
......
...@@ -70,7 +70,6 @@ blacklist: ...@@ -70,7 +70,6 @@ blacklist:
sd/inc/TransitionPreset.hxx: sd/inc/TransitionPreset.hxx:
# base class has to be a complete type # base class has to be a complete type
- com/sun/star/lang/XMultiServiceFactory.hpp - com/sun/star/lang/XMultiServiceFactory.hpp
- memory
sd/inc/undoanim.hxx: sd/inc/undoanim.hxx:
# base class has to be a complete type # base class has to be a complete type
- com/sun/star/animations/XAnimationNode.hpp - com/sun/star/animations/XAnimationNode.hpp
...@@ -80,9 +79,6 @@ blacklist: ...@@ -80,9 +79,6 @@ blacklist:
sd/source/filter/eppt/eppt.hxx: sd/source/filter/eppt/eppt.hxx:
# base class has to be a complete type # base class has to be a complete type
- escherex.hxx - escherex.hxx
sd/source/filter/eppt/pptexanimations.hxx:
# base class has to be a complete type
- memory
sd/source/ui/inc/AccessibleDocumentViewBase.hxx: sd/source/ui/inc/AccessibleDocumentViewBase.hxx:
# base class has to be a complete type # base class has to be a complete type
- com/sun/star/accessibility/XAccessibleExtendedAttributes.hpp - com/sun/star/accessibility/XAccessibleExtendedAttributes.hpp
...@@ -124,4 +120,4 @@ blacklist: ...@@ -124,4 +120,4 @@ blacklist:
- sfx2/sfxbasecontroller.hxx - sfx2/sfxbasecontroller.hxx
sd/source/ui/inc/fupage.hxx: sd/source/ui/inc/fupage.hxx:
# base class has to be a complete type # base class has to be a complete type
- vcl/weld.hxx - vcl/weld.hxx
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment