Some cppcheck cleaning

embeddedobj/source/msole/olecomponent.cxx

@@ -478,7 +478,7 @@ OleComponent::~OleComponent()
 
     for ( FormatEtcList::iterator aIter = m_pNativeImpl->m_aFormatsList.begin();
           aIter != m_pNativeImpl->m_aFormatsList.end();
-          aIter++ )
+          ++aIter )
     {
         delete (*aIter);
         (*aIter) = NULL;
@@ -500,7 +500,7 @@ FORMATETC* OleComponentNative_Impl::GetSupportedFormatForAspect( sal_uInt32 nReq
 {
     for ( FormatEtcList::iterator aIter = m_aFormatsList.begin();
           aIter != m_aFormatsList.end();
-          aIter++ )
+          ++aIter )
         if ( (*aIter) && (*aIter)->dwAspect == nRequestedAspect )
             return (*aIter);
 

embeddedobj/test/MainThreadExecutor/xexecutor.hxx

@@ -81,7 +81,7 @@ public:
 
     DECL_LINK( executor, void* );
 
-    sal_Bool isExecuted() { return m_bExecuted; }
+    sal_Bool isExecuted() const { return m_bExecuted; }
 };
 
 #endif

framework/source/fwe/xml/saxnamespacefilter.cxx

@@ -117,7 +117,7 @@ void SAL_CALL SaxNamespaceFilter::startElement(
     catch ( SAXException& e )
     {
         e.Message = ::rtl::OUString( getErrorLineString() + e.Message );
-        throw e;
+        throw;
     }
 
     ::rtl::OUString aNamespaceElementName;
@@ -129,7 +129,7 @@ void SAL_CALL SaxNamespaceFilter::startElement(
     catch ( SAXException& e )
     {
         e.Message = ::rtl::OUString( getErrorLineString() + e.Message );
-        throw e;
+        throw;
     }
 
     xDocumentHandler->startElement( aNamespaceElementName, pNewList );
@@ -148,7 +148,7 @@ void SAL_CALL SaxNamespaceFilter::endElement(const rtl::OUString& aName)
     catch ( SAXException& e )
     {
         e.Message = ::rtl::OUString( getErrorLineString() + e.Message );
-        throw e;
+        throw;
     }
 
     xDocumentHandler->endElement( aNamespaceElementName );

framework/source/fwe/xml/toolboxdocumenthandler.cxx

@@ -398,8 +398,6 @@ throw(  SAXException, RuntimeException )
                                             nItemBits |= ::com::sun::star::ui::ItemStyle::ALIGN_LEFT;
                                         else if ( nHashCode == m_nHashCode_Style_AutoSize )
                                             nItemBits |= ::com::sun::star::ui::ItemStyle::AUTO_SIZE;
-                                        else if ( nHashCode == m_nHashCode_Style_DropDown )
-                                            nItemBits |= ::com::sun::star::ui::ItemStyle::DROP_DOWN;
                                         else if ( nHashCode == m_nHashCode_Style_Repeat )
                                             nItemBits |= ::com::sun::star::ui::ItemStyle::REPEAT;
                                         else if ( nHashCode == m_nHashCode_Style_DropDownOnly )

framework/source/uielement/newmenucontroller.cxx

@@ -531,7 +531,7 @@ void NewMenuController::impl_setPopupMenu()
         }
         catch ( RuntimeException& e )
         {
-            throw e;
+            throw;
         }
         catch ( Exception& )
         {

framework/source/uielement/spinfieldtoolbarcontroller.cxx

@@ -373,12 +373,11 @@ void SpinfieldToolbarController::executeControlCommand( const ::com::sun::star::
     {
         for ( sal_Int32 i = 0; i < rControlCommand.Arguments.getLength(); i++ )
         {
-            sal_Int32   nValue;
-            double      fValue;
-            bool        bFloat( false );
-
             if ( rControlCommand.Arguments[i].Name.equalsAsciiL( "Step", 4 ))
             {
+                sal_Int32   nValue;
+                double      fValue;
+                bool        bFloat( false );
                 if ( impl_getValue( rControlCommand.Arguments[i].Value, nValue, fValue, bFloat ))
                     aStep = bFloat ? ::rtl::OUString::valueOf( fValue ) :
                                      ::rtl::OUString::valueOf( nValue );
@@ -439,12 +438,11 @@ void SpinfieldToolbarController::executeControlCommand( const ::com::sun::star::
     {
         for ( sal_Int32 i = 0; i < rControlCommand.Arguments.getLength(); i++ )
         {
-            sal_Int32   nValue;
-            double      fValue;
-            bool        bFloat( false );
-
             if ( rControlCommand.Arguments[i].Name.equalsAsciiL( "LowerLimit", 10 ))
             {
+                sal_Int32   nValue;
+                double      fValue;
+                bool        bFloat( false );
                 if ( impl_getValue( rControlCommand.Arguments[i].Value, nValue, fValue, bFloat ))
                     aMin = bFloat ? ::rtl::OUString::valueOf( fValue ) :
                                     ::rtl::OUString::valueOf( nValue );
@@ -456,12 +454,11 @@ void SpinfieldToolbarController::executeControlCommand( const ::com::sun::star::
     {
         for ( sal_Int32 i = 0; i < rControlCommand.Arguments.getLength(); i++ )
         {
-            sal_Int32   nValue;
-            double      fValue;
-            bool        bFloat( false );
-
             if ( rControlCommand.Arguments[i].Name.equalsAsciiL( "UpperLimit", 10 ))
             {
+                sal_Int32   nValue;
+                double      fValue;
+                bool        bFloat( false );
                 if ( impl_getValue( rControlCommand.Arguments[i].Value, nValue, fValue, bFloat ))
                     aMax = bFloat ? ::rtl::OUString::valueOf( fValue ) :
                                     ::rtl::OUString::valueOf( nValue );

framework/source/uielement/toolbarmanager.cxx

@@ -1584,7 +1584,7 @@ void ToolBarManager::notifyRegisteredControllers( const rtl::OUString& aUIElemen
                     }
                     catch ( RuntimeException& e )
                     {
-                        throw e;
+                        throw;
                     }
                     catch ( Exception& )
                     {