Kaydet (Commit) 476bef70 authored tarafından Tor Lillqvist's avatar Tor Lillqvist

tdf#94924: If we can't handle strings, don't try to then

Fixes the VLOOKUP problem reported in tdf#94540 by falling back to
non-OpenCL for such a case, where one of the columns passed to the
VLOOKUP contained strings. And since a while, we don't claim to handle
strings in VLOOKUP. Which is true.

Change-Id: I4140c86bf8166beb8201aa90c075d9f4432d9173
üst a80c3a5c
...@@ -2657,6 +2657,13 @@ DynamicKernelSoPArguments::DynamicKernelSoPArguments(const ScCalcConfig& config, ...@@ -2657,6 +2657,13 @@ DynamicKernelSoPArguments::DynamicKernelSoPArguments(const ScCalcConfig& config,
new DynamicKernelMixedSlidingArgument(mCalcConfig, new DynamicKernelMixedSlidingArgument(mCalcConfig,
ts, ft->Children[i], mpCodeGen, j))); ts, ft->Children[i], mpCodeGen, j)));
} }
else if (!AllStringsAreNull(pDVR->GetArrays()[j].mpStringArray, pDVR->GetArrayLength()) &&
!pCodeGen->takeString())
{
// Can't handle
SAL_INFO("sc.opencl", "Strings but can't do that.");
throw UnhandledToken(pChild, ("unhandled operand " + StackVarEnumToString(pChild->GetType()) + " for ocPush").c_str());
}
else else
{ {
// Not sure I can figure out what case this exactly is;) // Not sure I can figure out what case this exactly is;)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment