cppcheck:noExplicitConstructor in webdav, serf version

Explicitly add constructors that where previously hidden.

The right implementation of what I did
in aade7198.

The explict keyword was added in 6343754e

Change-Id: I66f6ee51c8b51d93d6ac673e75555e13024e4b48
Reviewed-on: https://gerrit.libreoffice.org/17823Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

ucb/source/ucp/webdav/ContentProperties.cxx

@@ -591,11 +591,6 @@ CachableContentProperties::CachableContentProperties(
     addProperties( rProps );
 }
 
-CachableContentProperties::CachableContentProperties(
-     const DAVResource & rResource )
-{
-    addProperties( rResource );
-}
 
 void CachableContentProperties::addProperties(
     const ContentProperties & rProps )
@@ -616,6 +611,7 @@ void CachableContentProperties::addProperties(
     }
 }
 
+
 void CachableContentProperties::addProperties(
     const std::vector< DAVPropertyValue > & rProps )
 {
@@ -631,9 +627,4 @@ void CachableContentProperties::addProperties(
      }
 }
 
-void CachableContentProperties::addProperties( const DAVResource & rResource )
-{
-    addProperties( rResource.properties );
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

ucb/source/ucp/webdav/ContentProperties.hxx

@@ -173,15 +173,12 @@ private:
     CachableContentProperties( const CachableContentProperties & ); // n.i.
 
 public:
-    explicit CachableContentProperties( const DAVResource& rResource );
     explicit CachableContentProperties( const ContentProperties & rProps );
 
     void addProperties( const ContentProperties & rProps );
 
     void addProperties( const std::vector< DAVPropertyValue > & rProps );
 
-    void addProperties( const DAVResource & rResource );
-
     bool containsAllNames(
                     const com::sun::star::uno::Sequence<
                         com::sun::star::beans::Property >& rProps,

ucb/source/ucp/webdav/webdavcontent.cxx

@@ -2169,9 +2169,9 @@ uno::Any Content::open(
                     // cache headers.
                     if ( !m_xCachedProps.get())
                         m_xCachedProps.reset(
-                            new CachableContentProperties( aResource ) );
+                            new CachableContentProperties( ContentProperties( aResource ) ) );
                     else
-                        m_xCachedProps->addProperties( aResource );
+                        m_xCachedProps->addProperties( ContentProperties( aResource ) );
 
                     m_xResAccess.reset(
                         new DAVResourceAccess( *xResAccess.get() ) );
@@ -2215,7 +2215,7 @@ uno::Any Content::open(
                         // cache headers.
                         if ( !m_xCachedProps.get())
                             m_xCachedProps.reset(
-                                new CachableContentProperties( aResource ) );
+                                new CachableContentProperties( ContentProperties( aResource ) ) );
                         else
                             m_xCachedProps->addProperties(
                                 aResource.properties );
@@ -3362,7 +3362,7 @@ Content::ResourceType Content::getResourceType(
         {
             osl::MutexGuard g(m_aMutex);
             m_xCachedProps.reset(
-                new CachableContentProperties( resources[ 0 ] ) );
+                new CachableContentProperties( ContentProperties( resources[ 0 ] ) ) );
             m_xCachedProps->containsAllNames(
                 aProperties, m_aFailedPropNames );
         }