Kaydet (Commit) 4964cb80 authored tarafından Julien Nabet's avatar Julien Nabet

tdf#118374: fix crash from loplugin:useuniqueptr in sdext

See bt:
https://bugs.documentfoundation.org/attachment.cgi?id=143105

Regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a9ef943769b06e6bdffe7326f288b27e08a95698

Change-Id: I285f00cb6ede3d952a794b60ff64586fe2224e5f
Reviewed-on: https://gerrit.libreoffice.org/56490Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
üst e1a77d0a
...@@ -447,7 +447,6 @@ void PageElement::resolveUnderlines( PDFIProcessor const & rProc ) ...@@ -447,7 +447,6 @@ void PageElement::resolveUnderlines( PDFIProcessor const & rProc )
auto next_it = poly_it; auto next_it = poly_it;
++next_it; ++next_it;
Children.erase( poly_it ); Children.erase( poly_it );
delete pPoly;
poly_it = next_it; poly_it = next_it;
} }
else else
......
...@@ -419,7 +419,6 @@ void WriterXmlOptimizer::visit( PolyPolyElement& elem, const std::list< std::uni ...@@ -419,7 +419,6 @@ void WriterXmlOptimizer::visit( PolyPolyElement& elem, const std::list< std::uni
#else #else
elem.Parent->Children.erase(next_it); elem.Parent->Children.erase(next_it);
#endif #endif
delete pNext;
} }
} }
...@@ -819,7 +818,6 @@ void WriterXmlOptimizer::optimizeTextElements(Element& rParent) ...@@ -819,7 +818,6 @@ void WriterXmlOptimizer::optimizeTextElements(Element& rParent)
pCur->Children.splice( pCur->Children.end(), pNext->Children ); pCur->Children.splice( pCur->Children.end(), pNext->Children );
// get rid of the now useless element // get rid of the now useless element
rParent.Children.erase( next ); rParent.Children.erase( next );
delete pNext;
bConcat = true; bConcat = true;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment