Revert "startcenter: react on mouse down instead"

This reverts commit 1a2a961c.

As suggested by Kendy, opening with a single click
by mouse up is more natural. We need to find a better
solution for the bug mentioned in the above commit.

include/sfx2/recentdocsview.hxx

@@ -63,6 +63,8 @@ public:
 protected:
     virtual void MouseButtonDown( const MouseEvent& rMEvt ) SAL_OVERRIDE;
 
+    virtual void MouseButtonUp( const MouseEvent& rMEvt ) SAL_OVERRIDE;
+
     virtual void OnItemDblClicked(ThumbnailViewItem *pItem) SAL_OVERRIDE;
 
     virtual void Paint( const Rectangle& rRect ) SAL_OVERRIDE;

include/sfx2/recentdocsviewitem.hxx

@@ -33,7 +33,7 @@ public:
     virtual void Paint(drawinglayer::processor2d::BaseProcessor2D *pProcessor,
                        const ThumbnailItemAttributes *pAttrs) SAL_OVERRIDE;
 
-    virtual void MouseButtonDown(const MouseEvent& rMEvt) SAL_OVERRIDE;
+    virtual void MouseButtonUp(const MouseEvent& rMEvt) SAL_OVERRIDE;
 
     /// Called when the user clicks a document - it will open it.
     void OpenDocument();

include/sfx2/thumbnailviewitem.hxx

@@ -129,7 +129,7 @@ public:
     static drawinglayer::primitive2d::PolygonHairlinePrimitive2D*
         createBorderLine (const basegfx::B2DPolygon &rPolygon);
 
-    virtual void MouseButtonDown(const MouseEvent&) {}
+    virtual void MouseButtonUp(const MouseEvent&) {}
 
 protected:
 

sfx2/source/control/recentdocsview.cxx

@@ -213,19 +213,27 @@ void RecentDocsView::MouseButtonDown( const MouseEvent& rMEvt )
 {
     if (rMEvt.IsLeft())
     {
-        if (rMEvt.GetClicks() > 1)
-            return;
+        // ignore to avoid stuff done in ThumbnailView; we don't do selections etc.
+        return;
+    }
+
+    ThumbnailView::MouseButtonDown(rMEvt);
+}
 
+void RecentDocsView::MouseButtonUp(const MouseEvent& rMEvt)
+{
+    if (rMEvt.IsLeft())
+    {
         size_t nPos = ImplGetItem(rMEvt.GetPosPixel());
         ThumbnailViewItem* pItem = ImplGetItem(nPos);
 
         if (pItem)
         {
-            pItem->MouseButtonDown(rMEvt);
+            pItem->MouseButtonUp(rMEvt);
             return;
         }
     }
-    ThumbnailView::MouseButtonDown(rMEvt);
+    ThumbnailView::MouseButtonUp(rMEvt);
 }
 
 void RecentDocsView::OnItemDblClicked(ThumbnailViewItem *)

sfx2/source/control/recentdocsviewitem.cxx

@@ -182,7 +182,7 @@ void RecentDocsViewItem::Paint(drawinglayer::processor2d::BaseProcessor2D *pProc
     }
 }
 
-void RecentDocsViewItem::MouseButtonDown(const MouseEvent& rMEvt)
+void RecentDocsViewItem::MouseButtonUp(const MouseEvent& rMEvt)
 {
     if (rMEvt.IsLeft())
     {