Kaydet (Commit) 4c4999d9 authored tarafından Jan Holesovsky's avatar Jan Holesovsky

tdf#96042: 'std::string::find("something") == 0' means "startsWith()".

This should fix a regression from 3bdd1767,
apparently the cppcheck's advice is misleading.

Change-Id: I427ecaa1eb3c9841cb6112997b9b51feda4583d0
üst de7018f7
......@@ -103,7 +103,7 @@ bool PassStuffByRef::isFat(QualType type, std::string * name) {
}
*name = type.getUnqualifiedType().getCanonicalType().getAsString();
if (*name == "class rtl::OUString" || *name == "class rtl::OString"
|| name->compare("class com::sun::star::uno::Sequence") == 0)
|| name->compare(0, 35, "class com::sun::star::uno::Sequence") == 0)
{
return true;
}
......
......@@ -334,7 +334,7 @@ void myparser::traverse( xmlNodePtr parentNode )
std::string hid;
if (branch.compare("hid") == 0)
if (branch.compare(0, 3, "hid") != 0)
{
size_t index = branch.find('/');
if (index != std::string::npos)
......@@ -492,7 +492,7 @@ bool HelpCompiler::compile()
if ( !bExtensionMode && !fileName.empty())
{
if (fileName.compare("/text/") == 0)
if (fileName.compare(0, 6, "/text/") == 0)
{
int len = strlen("/text/");
actMod = fileName.substr(len);
......
......@@ -396,7 +396,7 @@ void HelpLinker::link() throw(HelpProcessingException, BasicCodeTagger::TaggerEx
continue;
std::string documentPath = streamTable.document_path;
if (documentPath.compare("/") == 0)
if (documentPath.compare(0, 1, "/") == 0)
documentPath = documentPath.substr(1);
std::string documentJarfile = streamTable.document_module + ".jar";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment