resizing of optionalbox now follows priority order strictly

earlier box were not following the assigned priorities thus
causing the reordering issue

Change-Id: I8631312946322164a358d70fd9c47aa6ddfb95e2
Reviewed-on: https://gerrit.libreoffice.org/55644Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

sfx2/source/notebookbar/NotebookbarPopup.cxx

@@ -42,7 +42,8 @@ void NotebookbarPopup::PopupModeEnd()
         vcl::Window* pWindow = m_pBox->GetChild(0);
         pWindow->SetParent(m_pParent);
 
-        if (m_pParent)
+        // resize after all children of box are empty
+        if (m_pParent && !m_pBox->GetChildCount())
             m_pParent->Resize();
     }