loplugin:constantfunction: unotools

Change-Id: Icf543973dc9edde270016c8af7e4c08c57eff650

basctl/source/basicide/basobj2.cxx

@@ -243,7 +243,7 @@ OUString ChooseMacro( const uno::Reference< frame::XModel >& rxLimitToDocument,
     SbMethod* pMethod = NULL;
 
     boost::scoped_ptr< MacroChooser > pChooser( new MacroChooser( NULL, true ) );
-    if ( bChooseOnly || !SvtModuleOptions().IsBasicIDE() )
+    if ( bChooseOnly || !SvtModuleOptions::IsBasicIDE() )
         pChooser->SetMode(MacroChooser::ChooseOnly);
 
     if ( !bChooseOnly && rxLimitToDocument.is() )

basctl/source/basicide/basobj3.cxx

@@ -380,7 +380,7 @@ long HandleBasicError( StarBASIC* pBasic )
 
     long nRet = 0;
     Shell* pShell = 0;
-    if ( SvtModuleOptions().IsBasicIDE() )
+    if ( SvtModuleOptions::IsBasicIDE() )
     {
         BasicManager* pBasMgr = FindBasicManager( pBasic );
         if ( pBasMgr )

include/unotools/localedatawrapper.hxx

@@ -296,12 +296,12 @@ public:
     // dummy returns, to be implemented
     inline  sal_Unicode         getCurrZeroChar() const
                                     { return cCurrZeroChar; }
-    inline  bool                isNumLeadingZero() const
+    static inline  bool         isNumLeadingZero()
                                     { return true; }
                                 /// standard decimal places
-    inline  sal_uInt16              getNumDigits() const
+    static inline sal_uInt16    getNumDigits()
                                     { return 2; }
-    inline  bool                isNumTrailingZeros() const
+    static inline  bool         isNumTrailingZeros()
                                     { return true; }
 
     // reserved words

include/unotools/moduleoptions.hxx

@@ -161,7 +161,7 @@ class UNOTOOLS_DLLPUBLIC SAL_WARN_UNUSED SvtModuleOptions : public utl::detail::
         bool   IsDraw     () const;
         bool   IsWriter   () const;
         bool   IsImpress  () const;
-        bool   IsBasicIDE () const;
+        static bool   IsBasicIDE () { return true; }
         bool   IsDataBase () const;
 
         ::com::sun::star::uno::Sequence < OUString > GetAllServiceNames();

svx/source/svdraw/svdattr.cxx

@@ -870,7 +870,7 @@ bool SdrAngleItem::GetPresentation(
             pIntlWrapper = pMyIntlWrapper = new IntlWrapper(
                 Application::GetSettings().GetLanguageTag() );
 
-        if(pIntlWrapper->getLocaleData()->isNumLeadingZero())
+        if(LocaleDataWrapper::isNumLeadingZero())
             nCount++;
 
         while(aText.getLength() < nCount)

svx/source/svdraw/svdmodel.cxx

@@ -1224,7 +1224,7 @@ void SdrModel::TakeMetricStr(long nVal, OUString& rStr, bool bNoUnitChars, sal_I
 
     if( -1 == nNumDigits )
     {
-        nNumDigits = rLoc.getNumDigits();
+        nNumDigits = LocaleDataWrapper::getNumDigits();
     }
 
     sal_Int32 nKomma(nUIUnitKomma);
@@ -1267,7 +1267,7 @@ void SdrModel::TakeMetricStr(long nVal, OUString& rStr, bool bNoUnitChars, sal_I
         // if necessary, add zeros before the decimal point
         sal_Int32 nAnz = nKomma - aBuf.getLength();
 
-        if(nAnz >= 0 && rLoc.isNumLeadingZero())
+        if(nAnz >= 0 && LocaleDataWrapper::isNumLeadingZero())
             nAnz++;
 
         for(sal_Int32 i=0; i<nAnz; i++)
@@ -1282,7 +1282,7 @@ void SdrModel::TakeMetricStr(long nVal, OUString& rStr, bool bNoUnitChars, sal_I
     if(nKomma > 0)
         aBuf.insert(nVorKomma, cDec);
 
-    if(!rLoc.isNumTrailingZeros())
+    if(!LocaleDataWrapper::isNumTrailingZeros())
     {
         // Remove all trailing zeros.
         while (!aBuf.isEmpty() && aBuf[aBuf.getLength()-1] == '0')
@@ -1338,7 +1338,7 @@ void SdrModel::TakeAngleStr(long nAngle, OUString& rStr, bool bNoDegChar) const
     const LocaleDataWrapper& rLoc = aSysLoc.GetLocaleData();
     sal_Int32 nAnz = 2;
 
-    if(rLoc.isNumLeadingZero())
+    if(LocaleDataWrapper::isNumLeadingZero())
         nAnz++;
 
     while(aBuf.getLength() < nAnz)

svx/source/svdraw/svdtrans.cxx

@@ -867,7 +867,7 @@ void SdrFormatter::TakeStr(long nVal, OUString& rStr) const
             aStr.insert(0, aNullCode);
 
         // remove superfluous decimal points
-        sal_Int32 nNumDigits(rLoc.getNumDigits());
+        sal_Int32 nNumDigits(LocaleDataWrapper::getNumDigits());
         sal_Int32 nWeg(nC - nNumDigits);
 
         if(nWeg > 0)

unotools/source/config/moduleoptions.cxx

@@ -1044,11 +1044,6 @@ bool SvtModuleOptions::IsImpress() const
     return m_pDataContainer->IsModuleInstalled( E_SIMPRESS );
 }
 
-bool SvtModuleOptions::IsBasicIDE() const
-{
-    return true;
-}
-
 bool SvtModuleOptions::IsDataBase() const
 {
     ::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );