Kaydet (Commit) 4fcbf856 authored tarafından Xisco Fauli's avatar Xisco Fauli Kaydeden (comit) Noel Grandin

tdf#89329: use unique_ptr for pImpl in dialog

Change-Id: Ic08e35a08f3f72383be305e3458b83fe06e3e1a5
Reviewed-on: https://gerrit.libreoffice.org/25902Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noelgrandin@gmail.com>
üst cc813c94
...@@ -37,7 +37,7 @@ public: ...@@ -37,7 +37,7 @@ public:
private: private:
VclPtr<Dialog> mpPrevExecuteDlg; VclPtr<Dialog> mpPrevExecuteDlg;
DialogImpl* mpDialogImpl; std::unique_ptr<DialogImpl> mpDialogImpl;
long mnMousePositioned; long mnMousePositioned;
bool mbInExecute; bool mbInExecute;
bool mbInClose; bool mbInClose;
......
...@@ -362,7 +362,7 @@ void Dialog::ImplInitDialogData() ...@@ -362,7 +362,7 @@ void Dialog::ImplInitDialogData()
mpContentArea.clear(); mpContentArea.clear();
mpActionArea.clear(); mpActionArea.clear();
mnMousePositioned = 0; mnMousePositioned = 0;
mpDialogImpl = new DialogImpl; mpDialogImpl.reset(new DialogImpl);
} }
void Dialog::ImplInit( vcl::Window* pParent, WinBits nStyle, InitFlag eFlag ) void Dialog::ImplInit( vcl::Window* pParent, WinBits nStyle, InitFlag eFlag )
...@@ -583,8 +583,7 @@ Dialog::~Dialog() ...@@ -583,8 +583,7 @@ Dialog::~Dialog()
void Dialog::dispose() void Dialog::dispose()
{ {
delete mpDialogImpl; mpDialogImpl.reset();
mpDialogImpl = nullptr;
mpPrevExecuteDlg.clear(); mpPrevExecuteDlg.clear();
mpActionArea.clear(); mpActionArea.clear();
mpContentArea.clear(); mpContentArea.clear();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment