Kaydet (Commit) 527440c9 authored tarafından Miklos Vajna's avatar Miklos Vajna

oox: fix a few bogus SAL_WARN

The idea is that when an element is unhandled, it's either unhandled
explicitly by an empty "case..break" block (so grep can quickly find it)
or we raise a warning. Add a few placeholders for cases that we won't
probably handle better in the near future to silence warnings.

Change-Id: I41dec7802c4671550130393b4f98a8f0d8dfc059
üst c5a51893
...@@ -103,6 +103,7 @@ ContextHandlerRef ShapeContext::onCreateContext( sal_Int32 aElementToken, const ...@@ -103,6 +103,7 @@ ContextHandlerRef ShapeContext::onCreateContext( sal_Int32 aElementToken, const
case XML_txXfrm: case XML_txXfrm:
{ {
mpShapePtr->getTextBody()->getTextProperties().moRotation = rAttribs.getInteger( XML_rot ); mpShapePtr->getTextBody()->getTextProperties().moRotation = rAttribs.getInteger( XML_rot );
return 0;
break; break;
} }
case XML_cNvSpPr: case XML_cNvSpPr:
...@@ -120,6 +121,10 @@ ContextHandlerRef ShapeContext::onCreateContext( sal_Int32 aElementToken, const ...@@ -120,6 +121,10 @@ ContextHandlerRef ShapeContext::onCreateContext( sal_Int32 aElementToken, const
break; break;
case XML_nvPicPr: case XML_nvPicPr:
break; break;
case XML_relIds:
break;
case XML_nvSpPr:
break;
default: default:
SAL_WARN("oox", "ShapeContext::onCreateContext: unhandled element: " << getBaseToken(aElementToken)); SAL_WARN("oox", "ShapeContext::onCreateContext: unhandled element: " << getBaseToken(aElementToken));
break; break;
......
...@@ -75,6 +75,8 @@ ContextHandlerRef ShapeGroupContext::onCreateContext( sal_Int32 aElementToken, c ...@@ -75,6 +75,8 @@ ContextHandlerRef ShapeGroupContext::onCreateContext( sal_Int32 aElementToken, c
case XML_grpSpPr: case XML_grpSpPr:
return new ShapePropertiesContext( *this, *mpGroupShapePtr ); return new ShapePropertiesContext( *this, *mpGroupShapePtr );
case XML_nvGrpSpPr:
return 0;
case XML_spPr: case XML_spPr:
return new ShapePropertiesContext( *this, *mpGroupShapePtr ); return new ShapePropertiesContext( *this, *mpGroupShapePtr );
/* /*
......
...@@ -216,7 +216,7 @@ ContextHandlerRef TextCharacterPropertiesContext::onCreateContext( sal_Int32 aEl ...@@ -216,7 +216,7 @@ ContextHandlerRef TextCharacterPropertiesContext::onCreateContext( sal_Int32 aEl
} }
break; break;
default: default:
SAL_INFO("oox", "TextCharacterPropertiesContext::onCreateContext: unhandled element: " << getBaseToken(aElementToken)); SAL_WARN("oox", "TextCharacterPropertiesContext::onCreateContext: unhandled element: " << getBaseToken(aElementToken));
break; break;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment