loplugin:unusedfields in oox,package,reportdesign

Change-Id: I83d03dcc76b5f0d54ebb0513ae972acb0db8eef1

oox/inc/drawingml/chart/chartspacefragment.hxx

@@ -42,8 +42,6 @@ public:
     virtual             ~ChartSpaceFragment();
 
     virtual ::oox::core::ContextHandlerRef onCreateContext( sal_Int32 nElement, const AttributeList& rAttribs ) override;
-
-    ::oox::core::XmlFilterBase& mpFilterBase;
 };
 
 

oox/source/core/xmlfilterbase.cxx

@@ -164,7 +164,6 @@ struct XmlFilterBaseImpl
     Reference<XComponentContext>   mxContext;
     FastParser                     maFastParser;
     const OUString                 maBinSuffix;
-    const OUString                 maVmlSuffix;
     RelationsMap                   maRelationsMap;
     TextFieldStack                 maTextFieldStack;
 
@@ -175,8 +174,7 @@ struct XmlFilterBaseImpl
 XmlFilterBaseImpl::XmlFilterBaseImpl( const Reference< XComponentContext >& rxContext ) throw( RuntimeException ) :
     mxContext(rxContext),
     maFastParser( rxContext ),
-    maBinSuffix( ".bin" ),
-    maVmlSuffix( ".vml" )
+    maBinSuffix( ".bin" )
 {
     // register XML namespaces
     registerNamespaces(maFastParser);

oox/source/drawingml/chart/chartspacefragment.cxx

@@ -32,8 +32,7 @@ namespace chart {
 using namespace ::oox::core;
 
 ChartSpaceFragment::ChartSpaceFragment( XmlFilterBase& rFilter, const OUString& rFragmentPath, ChartSpaceModel& rModel ) :
-    FragmentBase< ChartSpaceModel >( rFilter, rFragmentPath, rModel ),
-    mpFilterBase(rFilter)
+    FragmentBase< ChartSpaceModel >( rFilter, rFragmentPath, rModel )
 {
 }
 

package/inc/ZipFile.hxx

@@ -56,7 +56,6 @@ class ZipFile
 protected:
     ::osl::Mutex    m_aMutex;
 
-    OUString sComment;       /* zip file comment */
     EntryHash       aEntries;
     ByteGrabber     aGrabber;
     ZipUtils::Inflater aInflater;

package/source/manifest/ManifestImport.hxx

@@ -61,13 +61,11 @@ protected:
     ::std::vector < css::uno::Sequence < css::beans::PropertyValue > > & rManVector;
 
     const OUString sFileEntryElement;
-    const OUString sManifestElement;
     const OUString sEncryptionDataElement;
     const OUString sAlgorithmElement;
     const OUString sStartKeyAlgElement;
     const OUString sKeyDerivationElement;
 
-    const OUString sCdataAttribute;
     const OUString sMediaTypeAttribute;
     const OUString sVersionAttribute;
     const OUString sFullPathAttribute;
@@ -95,8 +93,6 @@ protected:
     const OUString sStartKeyAlgProperty;
     const OUString sDigestAlgProperty;
 
-    const OUString sWhiteSpace;
-
     const OUString sSHA256_URL;
     const OUString sSHA1_Name;
     const OUString sSHA1_URL;

reportdesign/source/core/api/ReportComponent.cxx

@@ -65,7 +65,6 @@ OFormatProperties::OFormatProperties()
     ,nFontRelief(0)
     ,nTextColor(0)
     ,nTextLineColor(0)
-    ,nCharUnderlineColor(0xFFFFFFFF)
     ,nBackgroundColor(COL_TRANSPARENT)
     ,aVerticalAlignment( style::VerticalAlignment_TOP )
     ,nCharEscapement(0)

reportdesign/source/core/inc/ReportControlModel.hxx

@@ -53,7 +53,6 @@ namespace reportdesign
         ::sal_Int16                                         nFontRelief;
         ::sal_Int32                                         nTextColor;
         ::sal_Int32                                         nTextLineColor;
-        ::sal_Int32                                         nCharUnderlineColor;
         ::sal_Int32                                         nBackgroundColor;
         OUString                                            sCharCombinePrefix;
         OUString                                            sCharCombineSuffix;

reportdesign/source/filter/xml/xmlComponent.hxx

@@ -30,7 +30,6 @@ namespace rptxml
     {
     protected:
         css::uno::Reference< css::report::XReportComponent >  m_xComponent;
-        OUString m_sName;
         OUString m_sTextStyleName;
 
         OXMLComponent(const OXMLComponent&);

reportdesign/source/filter/xml/xmlExport.hxx

@@ -93,13 +93,6 @@ public:
         {}
     };
     typedef ::std::pair< OUString ,OUString> TStringPair;
-    typedef struct
-    {
-        OUString sText;
-        OUString sField;
-        OUString sDecimal;
-        OUString sThousand;
-    } TDelimiter;
     typedef ::std::vector< OUString>                         TStringVec;
     typedef ::std::map< Reference<XPropertySet> ,OUString >  TPropertyStyleMap;
     typedef ::std::map< Reference<XPropertySet> ,  TStringVec>      TGridStyleMap;
@@ -109,8 +102,6 @@ public:
     typedef ::std::map< Reference<XGroup> ,Reference<XFunction> >   TGroupFunctionMap;
 private:
     ::std::unique_ptr< TStringPair >                m_aAutoIncrement;
-    ::std::unique_ptr< TDelimiter >                 m_aDelimiter;
-    ::std::vector< Any >                            m_aDataSourceSettings;
     TSectionsGrid                                   m_aSectionsGrid;
 
     TPropertyStyleMap                               m_aAutoStyleNames;
@@ -118,7 +109,6 @@ private:
     TGridStyleMap                                   m_aRowStyleNames;
     TGroupFunctionMap                               m_aGroupFunctionMap;
 
-    OUString                                 m_sCharSet;
     OUString                                 m_sTableStyle;
     OUString                                 m_sCellStyle;
     OUString                                 m_sColumnStyle;

reportdesign/source/ui/inc/ColumnInfo.hxx

@@ -27,16 +27,13 @@ namespace rptui
     {
         OUString sColumnName;
         OUString sLabel;
-        bool bColumn;
         ColumnInfo(const OUString& i_sColumnName,const OUString& i_sLabel)
             : sColumnName(i_sColumnName)
             , sLabel(i_sLabel)
-            , bColumn(true)
         {
         }
         ColumnInfo(const OUString& i_sColumnName)
             : sColumnName(i_sColumnName)
-            , bColumn(false)
         {
         }
     };

reportdesign/source/ui/report/ReportControllerObserver.cxx

@@ -51,36 +51,29 @@ typedef std::map<uno::Reference< beans::XPropertySet >, AllProperties> PropertyS
 class OXReportControllerObserverImpl: private boost::noncopyable
 {
 public:
-    const OReportController&                            m_rReportController;
     ::std::vector< uno::Reference< container::XChild> > m_aSections;
     ::osl::Mutex                                        m_aMutex;
     oslInterlockedCount                                 m_nLocks;
     bool                                                m_bReadOnly;
 
-    explicit OXReportControllerObserverImpl(const OReportController& _rController);
-    ~OXReportControllerObserverImpl();
+    explicit OXReportControllerObserverImpl();
 };
 
 
 
-    OXReportControllerObserverImpl::OXReportControllerObserverImpl(const OReportController& _rController)
-            :m_rReportController(_rController)
-            ,m_nLocks(0)
+    OXReportControllerObserverImpl::OXReportControllerObserverImpl()
+            :m_nLocks(0)
             ,m_bReadOnly(false)
     {
     }
 
-    OXReportControllerObserverImpl::~OXReportControllerObserverImpl()
-    {
-    }
-
 
 
 
 
 
     OXReportControllerObserver::OXReportControllerObserver(const OReportController& _rController)
-            :m_pImpl(new OXReportControllerObserverImpl(_rController) )
+            :m_pImpl(new OXReportControllerObserverImpl )
             ,m_aFormattedFieldBeautifier(_rController)
             ,m_aFixedTextColor(_rController)
     {