loplugin:useuniqueptr in SvxClipBoardControl

Change-Id: Ib9e3d20680cba684fea8b586a5ca4c5835ca6b42
Reviewed-on: https://gerrit.libreoffice.org/49932Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/svx/clipboardctl.hxx

@@ -25,6 +25,7 @@
 #include <svl/poolitem.hxx>
 #include <svx/svxdllapi.h>
 #include <vcl/vclptr.hxx>
+#include <memory>
 
 class PopupMenu;
 class SfxModule;
@@ -32,7 +33,8 @@ class ToolBox;
 
 class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxClipBoardControl : public SfxToolBoxControl
 {
-    SfxPoolItem*            pClipboardFmtItem;
+    std::unique_ptr<SfxPoolItem>
+                            pClipboardFmtItem;
     VclPtr<PopupMenu>       pPopup;
     bool                    bDisabled;
 

svx/source/mnuctrls/clipboardctl.cxx

@@ -42,7 +42,6 @@ SvxClipBoardControl::SvxClipBoardControl(
         sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx ) :
 
     SfxToolBoxControl( nSlotId, nId, rTbx ),
-    pClipboardFmtItem( nullptr ),
     pPopup( nullptr ),
     bDisabled( false )
 {
@@ -56,13 +55,12 @@ SvxClipBoardControl::SvxClipBoardControl(
 SvxClipBoardControl::~SvxClipBoardControl()
 {
     DelPopup();
-    delete pClipboardFmtItem;
 }
 
 
 VclPtr<SfxPopupWindow> SvxClipBoardControl::CreatePopupWindow()
 {
-    const SvxClipboardFormatItem* pFmtItem = dynamic_cast<SvxClipboardFormatItem*>( pClipboardFmtItem  );
+    const SvxClipboardFormatItem* pFmtItem = dynamic_cast<SvxClipboardFormatItem*>( pClipboardFmtItem.get()  );
     if ( pFmtItem )
     {
         if (pPopup)
@@ -111,10 +109,10 @@ void SvxClipBoardControl::StateChanged( sal_uInt16 nSID, SfxItemState eState, co
 {
     if ( SID_CLIPBOARD_FORMAT_ITEMS == nSID )
     {
-        DELETEZ( pClipboardFmtItem );
+        pClipboardFmtItem.reset();
         if ( eState >= SfxItemState::DEFAULT )
         {
-            pClipboardFmtItem = pState->Clone();
+            pClipboardFmtItem.reset( pState->Clone() );
             GetToolBox().SetItemBits( GetId(), GetToolBox().GetItemBits( GetId() ) | ToolBoxItemBits::DROPDOWN );
         }
         else if ( !bDisabled )