Kaydet (Commit) 5e8911ef authored tarafından Caolán McNamara's avatar Caolán McNamara

pvs-studio: A part of conditional expression is always true: bCertValid.

Change-Id: Ia70f28fece45c84b4a460e379c5447818818e114
Reviewed-on: https://gerrit.libreoffice.org/62054Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst f90c2001
...@@ -645,20 +645,19 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox() ...@@ -645,20 +645,19 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
// If there is no storage, then it's pointless to check storage // If there is no storage, then it's pointless to check storage
// stream references. // stream references.
else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content
&& bCertValid && (maSignatureManager.mxStore.is() && !DocumentSignatureHelper::isOOo3_2_Signature( && (maSignatureManager.mxStore.is() && !DocumentSignatureHelper::isOOo3_2_Signature(
maSignatureManager.maCurrentSignatureInformations[n]))) maSignatureManager.maCurrentSignatureInformations[n])))
{ {
aImage = m_pSigsNotvalidatedImg->GetImage(); aImage = m_pSigsNotvalidatedImg->GetImage();
bAllNewSignatures = false; bAllNewSignatures = false;
} }
else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content
&& bCertValid && DocumentSignatureHelper::isOOo3_2_Signature( && DocumentSignatureHelper::isOOo3_2_Signature(
maSignatureManager.maCurrentSignatureInformations[n])) maSignatureManager.maCurrentSignatureInformations[n]))
{ {
aImage = m_pSigsValidImg->GetImage(); aImage = m_pSigsValidImg->GetImage();
} }
else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Macros else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Macros)
&& bCertValid)
{ {
aImage = m_pSigsValidImg->GetImage(); aImage = m_pSigsValidImg->GetImage();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment