fdo#38838 use OUString instead of String

Change-Id: I0c94a9ee10bd66422abd9526fcc9a9ce61d9a096
Reviewed-on: https://gerrit.libreoffice.org/6237Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

sw/source/filter/ww1/w1class.cxx

@@ -154,11 +154,11 @@ sal_uInt16 Ww1Style::ReadName( sal_uInt8*&p, sal_uInt16& rnCountBytes, sal_uInt1
             pStr = "?";
         else
             pStr = names[nSize-222];
-        SetName(String(pStr, RTL_TEXTENCODING_MS_1252));
+        SetName(OUString(pStr, strlen(pStr), RTL_TEXTENCODING_MS_1252));
     }
     else if( 255 > nCountBytes ) // unused
     {
-        SetName( String( (sal_Char*)p, nCountBytes, RTL_TEXTENCODING_MS_1252 ));
+        SetName( OUString( (sal_Char*)p, nCountBytes, RTL_TEXTENCODING_MS_1252 ));
         p += nCountBytes;
         OSL_ENSURE(rnCountBytes>=nCountBytes, "Ww1Style");
         rnCountBytes = rnCountBytes - nCountBytes;

sw/source/filter/ww1/w1class.hxx

@@ -16,7 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#include <tools/string.hxx>
+#include <rtl/ustring.hxx>
 
 // local
 #include <w1struct.hxx>

sw/source/ui/dialog/swabstdlg.cxx

@@ -21,7 +21,6 @@
 #include "swabstdlg.hxx"
 
 #include <osl/module.hxx>
-#include <tools/string.hxx>
 #include <vcl/unohelp.hxx>
 
 typedef SwAbstractDialogFactory* (SAL_CALL *SwFuncPtrCreateDialogFactory)();
@@ -42,7 +41,7 @@ SwAbstractDialogFactory* SwAbstractDialogFactory::Create()
     SwFuncPtrCreateDialogFactory fp = 0;
     static ::osl::Module aDialogLibrary;
     static const OUString sLibName(::vcl::unohelper::CreateLibraryName("swui", sal_True));
-    if ( aDialogLibrary.is() || aDialogLibrary.loadRelative( &thisModule, String( sLibName ),
+    if ( aDialogLibrary.is() || aDialogLibrary.loadRelative( &thisModule, sLibName,
                                                              SAL_LOADMODULE_GLOBAL | SAL_LOADMODULE_LAZY ) )
         fp = ( SwAbstractDialogFactory* (SAL_CALL*)() )
             aDialogLibrary.getFunctionSymbol( OUString("CreateDialogFactory"));

sw/source/ui/dialog/swdialmgr.cxx

@@ -18,13 +18,9 @@
  */
 
 #include "dialmgr.hxx"
-#include "tools/string.hxx"
 #include <sfx2/app.hxx>
 
 #ifndef DISABLE_DYNLOADING
-//copy from core\bastyp\swtypes.cxx
-String aEmptyStr; // constant strings
-
 ResMgr* pSwResMgr=0;
 #else
 static ResMgr *pSwResMgr;