remove unused code ScFormulaCell::GetErrorOrString

and then the now unused code in ScFormulaResult::GetErrorOrString

Change-Id: I95de8b5c24c0127cff61399eb6f38359040aace3

sc/inc/formulacell.hxx

@@ -284,7 +284,6 @@ public:
     sal_uInt16      GetErrCode();   // interpret first if necessary
     sal_uInt16      GetRawError();  // don't interpret, just return code or result error
     bool GetErrorOrValue( sal_uInt16& rErr, double& rVal );
-    bool GetErrorOrString( sal_uInt16& rErr, svl::SharedString& rStr );
     sc::FormulaResultValue GetResult();
     sal_uInt8       GetMatrixFlag() const;
     ScTokenArray* GetCode();

sc/inc/formularesult.hxx

@@ -155,7 +155,6 @@ public:
     bool IsMultiline() const;
 
     bool GetErrorOrDouble( sal_uInt16& rErr, double& rVal ) const;
-    bool GetErrorOrString( sal_uInt16& rErr, svl::SharedString& rStr ) const;
     sc::FormulaResultValue GetResult() const;
 
     /** Get error code if set or GetCellResultType() is formula::svError or svUnknown,

sc/source/core/data/formulacell.cxx

@@ -2348,17 +2348,6 @@ bool ScFormulaCell::GetErrorOrValue( sal_uInt16& rErr, double& rVal )
     return aResult.GetErrorOrDouble(rErr, rVal);
 }
 
-bool ScFormulaCell::GetErrorOrString( sal_uInt16& rErr, svl::SharedString& rStr )
-{
-    MaybeInterpret();
-
-    rErr = pCode->GetCodeError();
-    if (rErr)
-        return true;
-
-    return aResult.GetErrorOrString(rErr, rStr);
-}
-
 sc::FormulaResultValue ScFormulaCell::GetResult()
 {
     MaybeInterpret();

sc/source/core/tool/formularesult.cxx

@@ -345,42 +345,6 @@ bool ScFormulaResult::GetErrorOrDouble( sal_uInt16& rErr, double& rVal ) const
     return true;
 }
 
-bool ScFormulaResult::GetErrorOrString( sal_uInt16& rErr, svl::SharedString& rStr ) const
-{
-    if (mnError)
-    {
-        rErr = mnError;
-        return true;
-    }
-
-    formula::StackVar sv = GetCellResultType();
-    if (sv == formula::svError)
-    {
-        if (GetType() == formula::svMatrixCell)
-        {
-            // don't need to test for mpToken here, GetType() already did it
-            rErr = static_cast<const ScMatrixCellResultToken*>(mpToken)->
-                GetUpperLeftToken()->GetError();
-        }
-        else if (mpToken)
-        {
-            rErr = mpToken->GetError();
-        }
-    }
-
-    if (rErr)
-        return true;
-
-    if (!mbToken)
-        return false;
-
-    if (!isString(sv))
-        return false;
-
-    rStr = GetString();
-    return true;
-}
-
 sc::FormulaResultValue ScFormulaResult::GetResult() const
 {
     if (mnError)

unusedcode.easy

@@ -88,7 +88,6 @@ ScDocument::RebuildFormulaGroups()
 ScEditUtil::GetSpaceDelimitedString(EditTextObject const&)
 ScExtIButton::GetSelected() const
 ScFlatBoolRowSegments::getValue(int)
-ScFormulaCell::GetErrorOrString(unsigned short&, svl::SharedString&)
 ScFormulaCell::HasColRowName() const
 ScGlobal::GetStandardFormat(double, SvNumberFormatter&, unsigned long, short)
 ScGridWindow::HasScenarioRange(unsigned short, int, ScRange&)