Kaydet (Commit) 65ed07a8 authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#1078601 Dereference after null check

Change-Id: Ie708384cbf0a2b0faa82d0653ceb87816bcdcbfd
üst 013b1921
...@@ -83,11 +83,14 @@ void SwAccessibleTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem * ...@@ -83,11 +83,14 @@ void SwAccessibleTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem *
// #i73249# // #i73249#
case RES_TITLE_CHANGED: case RES_TITLE_CHANGED:
{ {
const OUString& sOldTitle( OUString sOldTitle, sNewTitle;
dynamic_cast<const SwStringMsgPoolItem&>(*pOld).GetString() ); const SwStringMsgPoolItem *pOldItem = dynamic_cast<const SwStringMsgPoolItem*>(pOld);
const OUString& sNewTitle( if (pOldItem)
dynamic_cast<const SwStringMsgPoolItem&>(*pNew).GetString() ); sOldTitle = pOldItem->GetString();
if ( sOldTitle == sNewTitle ) const SwStringMsgPoolItem *pNewItem = dynamic_cast<const SwStringMsgPoolItem*>(pNew);
if (pNewItem)
sNewTitle = pNewItem->GetString();
if (sOldTitle == sNewTitle)
{ {
break; break;
} }
...@@ -100,7 +103,7 @@ void SwAccessibleTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem * ...@@ -100,7 +103,7 @@ void SwAccessibleTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem *
const SwFlyFrmFmt* pFlyFrmFmt = const SwFlyFrmFmt* pFlyFrmFmt =
dynamic_cast<const SwFlyFrmFmt*>( pFlyFrm->GetFmt() ); dynamic_cast<const SwFlyFrmFmt*>( pFlyFrm->GetFmt() );
if ( !pFlyFrmFmt->GetObjDescription().isEmpty() ) if (!pFlyFrmFmt || !pFlyFrmFmt->GetObjDescription().isEmpty())
{ {
break; break;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment