loplugin:unusedmethods

Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb
Reviewed-on: https://gerrit.libreoffice.org/61576
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

chart2/source/controller/dialogs/res_LegendPosition.cxx

@@ -240,17 +240,6 @@ void LegendPositionResources::SetChangeHdl( const Link<LinkParamNone*,void>& rLi
     m_aChangeLink = rLink;
 }
 
-SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder)
-    : m_xCC() // unused in this scenario
-    , m_xCbxShow() // unused in this scenario, assumed to be visible
-    , m_xRbtLeft(rBuilder.weld_radio_button("left"))
-    , m_xRbtRight(rBuilder.weld_radio_button("right"))
-    , m_xRbtTop(rBuilder.weld_radio_button("top"))
-    , m_xRbtBottom(rBuilder.weld_radio_button("bottom"))
-{
-    impl_setRadioButtonToggleHdl();
-}
-
 SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder,
     const uno::Reference< uno::XComponentContext >& xCC)
     : m_xCC(xCC)
@@ -378,54 +367,6 @@ IMPL_LINK_NOARG(SchLegendPositionResources, PositionEnableHdl, weld::ToggleButto
     m_aChangeLink.Call(nullptr);
 }
 
-void SchLegendPositionResources::initFromItemSet( const SfxItemSet& rInAttrs )
-{
-    const SfxPoolItem* pPoolItem = nullptr;
-    if( rInAttrs.GetItemState( SCHATTR_LEGEND_POS, true, &pPoolItem ) == SfxItemState::SET )
-    {
-        chart2::LegendPosition nLegendPosition = static_cast<chart2::LegendPosition>(static_cast<const SfxInt32Item*>(pPoolItem)->GetValue());
-        switch( nLegendPosition )
-        {
-            case chart2::LegendPosition_LINE_START:
-                m_xRbtLeft->set_active(true);
-                break;
-            case chart2::LegendPosition_PAGE_START:
-                m_xRbtTop->set_active(true);
-                break;
-            case chart2::LegendPosition_LINE_END:
-                m_xRbtRight->set_active(true);
-                break;
-            case chart2::LegendPosition_PAGE_END:
-                m_xRbtBottom->set_active(true);
-                break;
-            default:
-                break;
-        }
-    }
-
-    if (m_xCbxShow && rInAttrs.GetItemState( SCHATTR_LEGEND_SHOW, true, &pPoolItem ) == SfxItemState::SET)
-    {
-        bool bShow = static_cast< const SfxBoolItem * >( pPoolItem )->GetValue();
-        m_xCbxShow->set_active(bShow);
-    }
-}
-
-void SchLegendPositionResources::writeToItemSet( SfxItemSet& rOutAttrs ) const
-{
-    chart2::LegendPosition nLegendPosition = chart2::LegendPosition_CUSTOM;
-    if( m_xRbtLeft->get_active() )
-        nLegendPosition = chart2::LegendPosition_LINE_START;
-    else if( m_xRbtTop->get_active() )
-        nLegendPosition = chart2::LegendPosition_PAGE_START;
-    else if( m_xRbtRight->get_active() )
-        nLegendPosition = chart2::LegendPosition_LINE_END;
-    else if( m_xRbtBottom->get_active() )
-        nLegendPosition = chart2::LegendPosition_PAGE_END;
-    rOutAttrs.Put( SfxInt32Item(SCHATTR_LEGEND_POS, static_cast<sal_Int32>(nLegendPosition) ) );
-
-    rOutAttrs.Put( SfxBoolItem(SCHATTR_LEGEND_SHOW, !m_xCbxShow || m_xCbxShow->get_active()) );
-}
-
 IMPL_LINK(SchLegendPositionResources, PositionChangeHdl, weld::ToggleButton&, rRadio, void )
 {
     //for each radio click there are coming two change events
@@ -435,11 +376,6 @@ IMPL_LINK(SchLegendPositionResources, PositionChangeHdl, weld::ToggleButton&, rR
         m_aChangeLink.Call(nullptr);
 }
 
-void SchLegendPositionResources::SetChangeHdl( const Link<LinkParamNone*,void>& rLink )
-{
-    m_aChangeLink = rLink;
-}
-
 } //namespace chart
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

chart2/source/controller/dialogs/res_Titles.cxx

@@ -174,28 +174,6 @@ SchTitleResources::~SchTitleResources()
 {
 }
 
-bool SchTitleResources::IsModified()
-{
-    return m_xEd_Main->get_value_changed_from_saved()
-        || m_xEd_Sub->get_value_changed_from_saved()
-        || m_xEd_XAxis->get_value_changed_from_saved()
-        || m_xEd_YAxis->get_value_changed_from_saved()
-        || m_xEd_ZAxis->get_value_changed_from_saved()
-        || m_xEd_SecondaryXAxis->get_value_changed_from_saved()
-        || m_xEd_SecondaryYAxis->get_value_changed_from_saved();
-}
-
-void SchTitleResources::ClearModifyFlag()
-{
-    m_xEd_Main->save_value();
-    m_xEd_Sub->save_value();
-    m_xEd_XAxis->save_value();
-    m_xEd_YAxis->save_value();
-    m_xEd_ZAxis->save_value();
-    m_xEd_SecondaryXAxis->save_value();
-    m_xEd_SecondaryYAxis->save_value();
-}
-
 void SchTitleResources::writeToResources( const TitleDialogData& rInput )
 {
     m_xFT_Main->set_sensitive( rInput.aPossibilityList[0] );

chart2/source/controller/inc/res_LegendPosition.hxx

@@ -74,8 +74,6 @@ class SchLegendPositionResources final
 {
 
 public:
-    //constructor without Display checkbox
-    SchLegendPositionResources(weld::Builder& rBuilder);
     //constructor inclusive Display checkbox
     SchLegendPositionResources(weld::Builder& rBuilder, const css::uno::Reference<
                        css::uno::XComponentContext>& xCC );
@@ -84,11 +82,6 @@ public:
     void writeToResources( const css::uno::Reference< css::frame::XModel >& xChartModel );
     void writeToModel( const css::uno::Reference< css::frame::XModel >& xChartModel ) const;
 
-    void initFromItemSet( const SfxItemSet& rInAttrs );
-    void writeToItemSet( SfxItemSet& rOutAttrs ) const;
-
-    void SetChangeHdl( const Link<LinkParamNone*,void>& rLink );
-
     DECL_LINK(PositionEnableHdl, weld::ToggleButton&, void);
     DECL_LINK(PositionChangeHdl, weld::ToggleButton&, void);
 

chart2/source/controller/inc/res_Titles.hxx

@@ -70,9 +70,6 @@ public:
     void writeToResources( const TitleDialogData& rInput );
     void readFromResources( TitleDialogData& rOutput );
 
-    bool IsModified();
-    void ClearModifyFlag();
-
 private:
     std::unique_ptr<weld::Label> m_xFT_Main;
     std::unique_ptr<weld::Label> m_xFT_Sub;

compilerplugins/clang/unusedmethods.unused-returns.results

@@ -144,8 +144,6 @@ include/sfx2/linkmgr.hxx:64
     _Bool sfx2::LinkManager::InsertLink(class sfx2::SvBaseLink *,unsigned short,enum SfxLinkUpdateMode,const class rtl::OUString *)
 include/sfx2/lnkbase.hxx:103
     class sfx2::SvLinkSource * sfx2::SvBaseLink::GetRealObject()
-include/svl/listener.hxx:55
-    _Bool SvtListener::EndListening(class SvtBroadcaster &)
 include/svl/macitem.hxx:92
     class SvStream & SvxMacroTableDtor::Write(class SvStream &) const
 include/svl/poolitem.hxx:173
@@ -198,9 +196,9 @@ include/vcl/texteng.hxx:279
     _Bool TextEngine::Read(class SvStream &,const class TextSelection *)
 include/vcl/toolbox.hxx:514
     _Bool ToolBox::ChangeHighlightUpDn(_Bool)
-include/vcl/weld.hxx:308
+include/vcl/weld.hxx:316
     _Bool weld::ComboBox::get_entry_selection_bounds(int &,int &)
-include/vcl/weld.hxx:947
+include/vcl/weld.hxx:956
     _Bool weld::TextView::get_selection_bounds(int &,int &)
 lotuswordpro/inc/lwpsvstream.hxx:76
     class LwpSvStream & LwpSvStream::ReadUInt8(unsigned char &)
@@ -274,7 +272,7 @@ sw/inc/editsh.hxx:264
     _Bool SwEditShell::GetPaMParAttr(class SwPaM *,class SfxItemSet &) const
 sw/inc/editsh.hxx:635
     const class GraphicAttr * SwEditShell::GetGraphicAttr(class GraphicAttr &) const
-sw/inc/IDocumentUndoRedo.hxx:180
+sw/inc/IDocumentUndoRedo.hxx:181
     _Bool IDocumentUndoRedo::Repeat(class sw::RepeatContext &,const unsigned short)
 sw/inc/swcrsr.hxx:156
     _Bool SwCursor::ExpandToSentenceBorders(const class SwRootFrame *)

cui/Library_cui.mk

@@ -177,7 +177,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
     cui/source/options/optupdt \
     $(call gb_Helper_optional,DESKTOP,\
         cui/source/options/personalization) \
-    cui/source/options/personasdochandler \
     cui/source/options/radiobtnbox \
     cui/source/options/sdbcdriverenum \
     cui/source/options/securityoptions \

cui/source/options/personalization.cxx

@@ -10,7 +10,6 @@
 #include <config_folders.h>
 
 #include "personalization.hxx"
-#include "personasdochandler.hxx"
 
 #include <comphelper/processfactory.hxx>
 #include <officecfg/Office/Common.hxx>

cui/source/options/personasdochandler.cxx

-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include "personasdochandler.hxx"
-
-using namespace ::com::sun::star;
-using namespace ::com::sun::star::uno;
-
-// XDocumentHandler
-void SAL_CALL
-PersonasDocHandler::startDocument()
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::endDocument()
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::characters( const OUString & aChars)
-{
-    if( m_isLearnmoreTag )
-        m_vLearnmoreURLs.push_back( aChars );
-}
-
-void SAL_CALL
-PersonasDocHandler::ignorableWhitespace( const OUString & )
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::processingInstruction(
-    const OUString &, const OUString & )
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::setDocumentLocator(
-    const Reference< xml::sax::XLocator >& )
-{
-}
-
-void SAL_CALL
-PersonasDocHandler::startElement( const OUString& aName,
-    const Reference< xml::sax::XAttributeList > &xAttribs )
-{
-    if( aName == "searchresults" )
-    {
-        OUString aTotalResults = xAttribs->getValueByName( "total_results" );
-        if( aTotalResults != "0" )
-            m_hasResults = true;
-    }
-
-    if ( aName == "learnmore" )
-        m_isLearnmoreTag = true;
-    else
-        m_isLearnmoreTag = false;
-}
-
-void SAL_CALL PersonasDocHandler::endElement( const OUString & )
-{
-}
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

cui/source/options/personasdochandler.hxx

-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
-
-#include <cppuhelper/implbase.hxx>
-#include <com/sun/star/xml/sax/XAttributeList.hpp>
-#include <com/sun/star/xml/sax/XParser.hpp>
-#include <vector>
-
-class PersonasDocHandler : public ::cppu::WeakImplHelper< css::xml::sax::XDocumentHandler >
-{
-private:
-    std::vector<OUString> m_vLearnmoreURLs;
-    bool m_isLearnmoreTag, m_hasResults;
-public:
-    PersonasDocHandler(){ m_isLearnmoreTag = false; m_hasResults = false; }
-    const std::vector<OUString>& getLearnmoreURLs() { return m_vLearnmoreURLs; }
-    bool hasResults() { return m_hasResults; }
-
-    // XDocumentHandler
-    virtual void SAL_CALL startDocument() override;
-
-    virtual void SAL_CALL endDocument() override;
-
-    virtual void SAL_CALL startElement( const OUString& aName,
-        const css::uno::Reference< css::xml::sax::XAttributeList > & xAttribs ) override;
-
-    virtual void SAL_CALL endElement( const OUString & aName ) override;
-
-    virtual void SAL_CALL characters( const OUString & aChars ) override;
-
-    virtual void SAL_CALL ignorableWhitespace( const OUString & aWhitespaces ) override;
-
-    virtual void SAL_CALL processingInstruction(
-        const OUString & aTarget, const OUString & aData ) override;
-
-    virtual void SAL_CALL setDocumentLocator(
-        const css::uno::Reference< css::xml::sax::XLocator >& xLocator ) override;
-};
-
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_PERSONASDOCHANDLER_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

include/sfx2/basedlgs.hxx

@@ -215,7 +215,6 @@ public:
     virtual             ~SfxSingleTabDialogController() override;
 
     void                SetTabPage(SfxTabPage* pTabPage);
-    SfxTabPage*         GetTabPage() const { return m_xSfxPage; }
     weld::Button&       GetOKButton() const { return *m_xOKBtn; }
 
     const SfxItemSet*   GetOutputItemSet() const { return m_xOutputSet.get(); }

include/sfx2/tabdlg.hxx

@@ -208,8 +208,6 @@ public:
     const CancelButton& GetCancelButton() const { return *m_pCancelBtn; }
     CancelButton&       GetCancelButton() { return *m_pCancelBtn; }
 
-    const PushButton*   GetUserButton() const { return m_pUserBtn; }
-    PushButton*         GetUserButton() { return m_pUserBtn; }
     void                RemoveResetButton();
     void                RemoveStandardButton();
 

include/svx/numfmtsh.hxx

@@ -166,7 +166,6 @@ public:
     sal_uInt16          FindCurrencyFormat(const NfCurrencyEntry* pTmpCurrencyEntry,bool bTmpBanking);
     void                SetCurCurrencyEntry(NfCurrencyEntry*);
     short               GetListPos4Entry(sal_uInt32 nIdx);
-    short               GetListPos4Entry( const OUString& rFmtString );
 
     void                GetCurrencySymbols(std::vector<OUString>& rList, sal_uInt16* pPos );
 

sc/inc/scmatrix.hxx

@@ -412,8 +412,6 @@ public:
     void MatConcat(SCSIZE nMaxCol, SCSIZE nMaxRow, const ScMatrixRef& xMat1, const ScMatrixRef& xMat2,
             SvNumberFormatter& rFormatter, svl::SharedStringPool& rPool) ;
 
-    ScMatrix& operator+= ( const ScMatrix& r );
-
 #if DEBUG_MATRIX
     void Dump() const;
 #endif

sc/source/core/tool/scmatrix.cxx

@@ -319,7 +319,6 @@ public:
 
     void GetDoubleArray( std::vector<double>& rArray, bool bEmptyAsZero ) const;
     void MergeDoubleArray( std::vector<double>& rArray, ScMatrix::Op eOp ) const;
-    void AddValues( const ScMatrixImpl& rMat );
 
     template<typename T>
     void ApplyOperation(T aOp, ScMatrixImpl& rMat);
@@ -2201,61 +2200,6 @@ void ScMatrixImpl::MergeDoubleArray( std::vector<double>& rArray, ScMatrix::Op e
     }
 }
 
-void ScMatrixImpl::AddValues( const ScMatrixImpl& rMat )
-{
-    const MatrixImplType& rOther = rMat.maMat;
-    MatrixImplType::size_pair_type aSize = maMat.size();
-    if (aSize != rOther.size())
-        // Geometry must match.
-        return;
-
-    // For now, we only add two matricies if and only if 1) the receiving
-    // matrix consists only of one numeric block, and 2) the other matrix
-    // consists of either one numeric block or one boolean block.  In the
-    // future, we may want to be more flexible support matricies that consist
-    // of multiple blocks.
-
-    MatrixImplType::position_type aPos1 = maMat.position(0, 0);
-    MatrixImplType::const_position_type aPos2 = rOther.position(0, 0);
-    if (MatrixImplType::to_mtm_type(aPos1.first->type) != mdds::mtm::element_numeric)
-        return;
-
-    if (aPos1.first->size != aPos2.first->size)
-        return;
-
-    if (aPos1.first->size != aSize.row * aSize.column)
-        return;
-
-    MatrixImplType::numeric_block_type::iterator it =
-        MatrixImplType::numeric_block_type::begin(*aPos1.first->data);
-    MatrixImplType::numeric_block_type::iterator itEnd =
-        MatrixImplType::numeric_block_type::end(*aPos1.first->data);
-
-    switch (MatrixImplType::to_mtm_type(aPos2.first->type))
-    {
-        case mdds::mtm::element_boolean:
-        {
-            MatrixImplType::boolean_block_type::iterator it2 =
-                MatrixImplType::boolean_block_type::begin(*aPos2.first->data);
-
-            for (; it != itEnd; ++it, ++it2)
-                *it += *it2;
-        }
-        break;
-        case mdds::mtm::element_numeric:
-        {
-            MatrixImplType::numeric_block_type::iterator it2 =
-                MatrixImplType::numeric_block_type::begin(*aPos2.first->data);
-
-            for (; it != itEnd; ++it, ++it2)
-                *it += *it2;
-        }
-        break;
-        default:
-            ;
-    }
-}
-
 namespace Op {
 
 template<typename T>
@@ -3529,12 +3473,6 @@ std::vector<ScMatrix::IterateResult> ScMatrix::Collect(const std::vector<std::un
     return pImpl->ApplyCollectOperation(aOp);
 }
 
-ScMatrix& ScMatrix::operator+= ( const ScMatrix& r )
-{
-    pImpl->AddValues(*r.pImpl);
-    return *this;
-}
-
 #if DEBUG_MATRIX
 void ScMatrix::Dump() const
 {

sc/source/ui/inc/validate.hxx

@@ -265,8 +265,6 @@ private:
     std::unique_ptr<weld::Entry> m_xEdtTitle;
     std::unique_ptr<weld::TextView> m_xEdInputHelp;
 
-    void    Init();
-
 public:
     ScTPValidationHelp(TabPageParent pParent, const SfxItemSet& rArgSet);
     virtual ~ScTPValidationHelp() override;

svx/source/items/numfmtsh.cxx

@@ -1354,31 +1354,6 @@ short SvxNumberFormatShell::GetListPos4Entry(sal_uInt32 nIdx)
     return nSelP;
 }
 
-short SvxNumberFormatShell::GetListPos4Entry(const OUString& rFmtString)
-{
-    sal_uInt32 nAt = 0;
-    short nSelP = SELPOS_NONE;
-    if (FindEntry(rFmtString, &nAt))
-    {
-        if (NUMBERFORMAT_ENTRY_NOT_FOUND != nAt && NUMBERFORMAT_ENTRY_NEW_CURRENCY != nAt)
-        {
-            nSelP = GetListPos4Entry(nAt);
-        }
-        else
-        {
-            for (size_t i = 0; i < aCurrencyFormatList.size(); i++)
-            {
-                if (rFmtString == aCurrencyFormatList[i])
-                {
-                    nSelP = static_cast<short>(i);
-                    break;
-                }
-            }
-        }
-    }
-    return nSelP;
-}
-
 OUString SvxNumberFormatShell::GetStandardName() const
 {
     return pFormatter->GetStandardName(eCurLanguage);