Kaydet (Commit) 698942ac authored tarafından Luboš Luňák's avatar Luboš Luňák

avoid valgrind uninitialized jump warning with clang

I'm not sure what exactly the actual problem is, but valgrind reports
unitialized reads of mbMulti, although that one is fine and the culprint
is in fact mbCenter. Which happens to be bit 16 of the bitfield, and
the generated assembly looks fishy, just for that one specific bit.
Adding extra padding, extra statements or even just reordering avoids it.
So this is lame, but just reorder it and be done with it, this should
be otherwise harmless and I've spent enough time on this.

Change-Id: I25be55ebe0e9b6dc981793aa7caeae2a40bb27a5
Reviewed-on: https://gerrit.libreoffice.org/63186
Tested-by: Jenkins
Reviewed-by: 's avatarLuboš Luňák <l.lunak@collabora.com>
üst 1fb3d85a
...@@ -215,8 +215,8 @@ private: ...@@ -215,8 +215,8 @@ private:
bool mbInUserDraw : 1; ///< In UserDraw bool mbInUserDraw : 1; ///< In UserDraw
bool mbReadOnly : 1; ///< ReadOnly bool mbReadOnly : 1; ///< ReadOnly
bool mbMirroring : 1; ///< pb: #106948# explicit mirroring for calc bool mbMirroring : 1; ///< pb: #106948# explicit mirroring for calc
bool mbRight : 1; ///< right align Text output
bool mbCenter : 1; ///< center Text output bool mbCenter : 1; ///< center Text output
bool mbRight : 1; ///< right align Text output
bool mbEdgeBlending : 1; bool mbEdgeBlending : 1;
Link<ImplListBoxWindow*,void> maScrollHdl; Link<ImplListBoxWindow*,void> maScrollHdl;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment