Kaydet (Commit) 6cf667cc authored tarafından Caolán McNamara's avatar Caolán McNamara

cppcheck: passedByValue

Change-Id: Id8b2db3b824ea40345aba99a5f24f2579c0ad630
üst 5e9db55d
...@@ -155,8 +155,10 @@ public: ...@@ -155,8 +155,10 @@ public:
namespace sw { namespace sw {
typedef std::function<SwTextFrame*()> Creator;
SwTextFrame * SwTextFrame *
SwHyphIterCacheLastTextFrame(SwTextNode *, std::function<SwTextFrame * ()>); SwHyphIterCacheLastTextFrame(SwTextNode *, const Creator& rCreator);
} }
......
...@@ -158,7 +158,7 @@ class SwHyphIter : public SwLinguIter ...@@ -158,7 +158,7 @@ class SwHyphIter : public SwLinguIter
// With that we save a GetFrame() in Hyphenate //TODO: does it actually matter? // With that we save a GetFrame() in Hyphenate //TODO: does it actually matter?
const SwTextNode *m_pLastNode; const SwTextNode *m_pLastNode;
SwTextFrame *m_pLastFrame; SwTextFrame *m_pLastFrame;
friend SwTextFrame * sw::SwHyphIterCacheLastTextFrame(SwTextNode *, std::function<SwTextFrame * ()>); friend SwTextFrame * sw::SwHyphIterCacheLastTextFrame(SwTextNode* pNode, const sw::Creator& rCreator);
bool bOldIdle; bool bOldIdle;
static void DelSoftHyph( SwPaM &rPam ); static void DelSoftHyph( SwPaM &rPam );
...@@ -573,7 +573,7 @@ namespace sw { ...@@ -573,7 +573,7 @@ namespace sw {
SwTextFrame * SwTextFrame *
SwHyphIterCacheLastTextFrame(SwTextNode *const pNode, SwHyphIterCacheLastTextFrame(SwTextNode *const pNode,
std::function<SwTextFrame * ()> const create) const sw::Creator& create)
{ {
assert(g_pHyphIter); assert(g_pHyphIter);
if (pNode != g_pHyphIter->m_pLastNode || !g_pHyphIter->m_pLastFrame) if (pNode != g_pHyphIter->m_pLastNode || !g_pHyphIter->m_pLastFrame)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment