Kaydet (Commit) 6d25220a authored tarafından Noel Grandin's avatar Noel Grandin

remove unnecessary use of OUString*

in FileList. There no benefit in storing a ref-counted value class like
OUString by pointer in a std::vector.

Change-Id: I302bc460de67c7fe324d745f3225df4e17195486
üst f85b2f67
......@@ -24,7 +24,8 @@
#include <tools/stream.hxx>
#include <vector>
typedef ::std::vector< OUString* > FileStringList;
typedef ::std::vector< OUString > FileStringList;
class SOT_DLLPUBLIC FileList : public SvDataCopyStream
{
......
......@@ -39,8 +39,6 @@ FileList::~FileList()
void FileList::ClearAll( void )
{
for ( size_t i = 0, n = aStrList.size(); i < n; ++i )
delete aStrList[ i ];
aStrList.clear();
}
......@@ -53,7 +51,7 @@ void FileList::ClearAll( void )
FileList& FileList::operator=( const FileList& rFileList )
{
for ( size_t i = 0, n = rFileList.aStrList.size(); i < n; ++i )
aStrList.push_back( new OUString( *rFileList.aStrList[ i ] ) );
aStrList.push_back( rFileList.aStrList[ i ] );
return *this;
}
......@@ -137,14 +135,14 @@ SvStream& operator>>( SvStream& rIStm, FileList& rFileList )
void FileList::AppendFile( const OUString& rStr )
{
aStrList.push_back( new OUString( rStr ) );
aStrList.push_back( rStr );
}
OUString FileList::GetFile( size_t i ) const
{
OUString aStr;
if( i < aStrList.size() )
aStr = *aStrList[ i ];
aStr = aStrList[ i ];
return aStr;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment