loplugin:returnconstant in ScDBDocFunc

Change-Id: Iaa71bbc2a10e46153209bf3264c74c8ce78f007b
Reviewed-on: https://gerrit.libreoffice.org/59124
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

sc/source/ui/docshell/dbdocimp.cxx

@@ -102,7 +102,7 @@ void ScDBDocFunc::ShowInBeamer( const ScImportParam& rParam, const SfxViewFrame*
     }
 }
 
-bool ScDBDocFunc::DoImportUno( const ScAddress& rPos,
+void ScDBDocFunc::DoImportUno( const ScAddress& rPos,
                                 const uno::Sequence<beans::PropertyValue>& aArgs )
 {
     svx::ODataAccessDescriptor aDesc( aArgs );      // includes selection and result set
@@ -113,8 +113,6 @@ bool ScDBDocFunc::DoImportUno( const ScAddress& rPos,
     OUString sTarget = pDBData->GetName();
 
     UpdateImport( sTarget, aDesc );
-
-    return true;
 }
 
 bool ScDBDocFunc::DoImport( SCTAB nTab, const ScImportParam& rParam,

sc/source/ui/inc/dbdocfun.hxx

@@ -62,7 +62,7 @@ public:
     bool DoImport( SCTAB nTab, const ScImportParam& rParam,
                    const svx::ODataAccessDescriptor* pDescriptor);      // used for selection an existing ResultSet
 
-    bool DoImportUno( const ScAddress& rPos,
+    void DoImportUno( const ScAddress& rPos,
                       const css::uno::Sequence<css::beans::PropertyValue>& aArgs );
 
     static void     ShowInBeamer( const ScImportParam& rParam, const SfxViewFrame* pFrame );

sc/source/ui/unoobj/dispuno.cxx

@@ -219,7 +219,8 @@ void SAL_CALL ScDispatch::dispatch( const util::URL& aURL,
         ScAddress aPos( rViewData.GetCurX(), rViewData.GetCurY(), rViewData.GetTabNo() );
 
         ScDBDocFunc aFunc( *rViewData.GetDocShell() );
-        bDone = aFunc.DoImportUno( aPos, aArgs );
+        aFunc.DoImportUno( aPos, aArgs );
+        bDone = true;
     }
     // cURLDocDataSource is never dispatched