Kaydet (Commit) 6ee4f634 authored tarafından Matteo Casalin's avatar Matteo Casalin

Simplify OUString and return early

Change-Id: I783b3fda560cddbbf5c196d20db6323972f62402
üst 5a5953b9
...@@ -270,7 +270,6 @@ ScDBData* ScDocShell::GetDBData( const ScRange& rMarked, ScGetDBMode eMode, ScGe ...@@ -270,7 +270,6 @@ ScDBData* ScDocShell::GetDBData( const ScRange& rMarked, ScGetDBMode eMode, ScGe
{ {
ScDBCollection* pUndoColl = nullptr; ScDBCollection* pUndoColl = nullptr;
OUString aNewName;
if (eMode==SC_DB_IMPORT) if (eMode==SC_DB_IMPORT)
{ {
aDocument.PreprocessDBDataUpdate(); aDocument.PreprocessDBDataUpdate();
...@@ -280,11 +279,11 @@ ScDBData* ScDocShell::GetDBData( const ScRange& rMarked, ScGetDBMode eMode, ScGe ...@@ -280,11 +279,11 @@ ScDBData* ScDocShell::GetDBData( const ScRange& rMarked, ScGetDBMode eMode, ScGe
long nCount = 0; long nCount = 0;
const ScDBData* pDummy = nullptr; const ScDBData* pDummy = nullptr;
ScDBCollection::NamedDBs& rDBs = pColl->getNamedDBs(); ScDBCollection::NamedDBs& rDBs = pColl->getNamedDBs();
OUString aNewName;
do do
{ {
++nCount; ++nCount;
aNewName = aImport; aNewName = aImport + OUString::number( nCount );
aNewName += OUString::number( nCount );
pDummy = rDBs.findByUpperName(ScGlobal::pCharClass->uppercase(aNewName)); pDummy = rDBs.findByUpperName(ScGlobal::pCharClass->uppercase(aNewName));
} }
while (pDummy); while (pDummy);
...@@ -296,8 +295,7 @@ ScDBData* ScDocShell::GetDBData( const ScRange& rMarked, ScGetDBMode eMode, ScGe ...@@ -296,8 +295,7 @@ ScDBData* ScDocShell::GetDBData( const ScRange& rMarked, ScGetDBMode eMode, ScGe
} }
else else
{ {
aNewName = STR_DB_LOCAL_NONAME; pNoNameData = new ScDBData(STR_DB_LOCAL_NONAME, nTab,
pNoNameData = new ScDBData(aNewName , nTab,
nStartCol,nStartRow, nEndCol,nEndRow, nStartCol,nStartRow, nEndCol,nEndRow,
true, bHasHeader ); true, bHasHeader );
aDocument.SetAnonymousDBData(nTab, pNoNameData); aDocument.SetAnonymousDBData(nTab, pNoNameData);
...@@ -474,19 +472,13 @@ void ScDocShell::RefreshPivotTables( const ScRange& rSource ) ...@@ -474,19 +472,13 @@ void ScDocShell::RefreshPivotTables( const ScRange& rSource )
static OUString lcl_GetAreaName( ScDocument* pDoc, ScArea* pArea ) static OUString lcl_GetAreaName( ScDocument* pDoc, ScArea* pArea )
{ {
OUString aName;
bool bOk = false;
ScDBData* pData = pDoc->GetDBAtArea( pArea->nTab, pArea->nColStart, pArea->nRowStart, ScDBData* pData = pDoc->GetDBAtArea( pArea->nTab, pArea->nColStart, pArea->nRowStart,
pArea->nColEnd, pArea->nRowEnd ); pArea->nColEnd, pArea->nRowEnd );
if (pData) if (pData)
{ return pData->GetName();
aName = pData->GetName();
bOk = true;
}
if (!bOk)
pDoc->GetName( pArea->nTab, aName );
OUString aName;
pDoc->GetName( pArea->nTab, aName );
return aName; return aName;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment