StartExecuteAsync doesn't need a second param

we can just use this to store a keep-alive reference in AsyncContext

Change-Id: I0152aef5386aa9753b48afdfc958790f10d13560
Reviewed-on: https://gerrit.libreoffice.org/48294Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

include/vcl/abstdlg.hxx

@@ -49,10 +49,10 @@ public:
         bool isSet() { return !!maEndDialogFn; }
     };
 
-    bool StartExecuteAsync(const std::function<void(sal_Int32)> &rEndDialogFn, VclPtr<VclReferenceBase> xOwner)
+    bool StartExecuteAsync(const std::function<void(sal_Int32)> &rEndDialogFn)
     {
         AsyncContext aCtx;
-        aCtx.mxOwner = xOwner;
+        aCtx.mxOwner = this;
         aCtx.maEndDialogFn = rEndDialogFn;
         return StartExecuteAsync(aCtx);
     }

include/vcl/dialog.hxx

@@ -142,11 +142,10 @@ public:
 
     // FIXME: Need to remove old StartExecuteModal in favour of this one.
     /// Returns true of the dialog successfully starts
-    bool StartExecuteAsync(const std::function<void(sal_Int32)> &rEndDialogFn,
-                           VclPtr<VclReferenceBase> xOwner = VclPtr<VclReferenceBase>())
+    bool StartExecuteAsync(const std::function<void(sal_Int32)> &rEndDialogFn)
     {
         VclAbstractDialog::AsyncContext aCtx;
-        aCtx.mxOwner = xOwner;
+        aCtx.mxOwner = this;
         aCtx.maEndDialogFn = rEndDialogFn;
         return StartExecuteAsync(aCtx);
     }

sc/source/ui/view/tabvwsha.cxx

@@ -561,7 +561,7 @@ void ScTabViewShell::ExecuteCellFormatDlg(SfxRequest& rReq, const OString &rName
 
                 pRequest->Done(*pOutSet);
             }
-        }, pDlg);
+        });
 }
 
 bool ScTabViewShell::IsRefInputMode() const

sd/source/ui/func/fuarea.cxx

@@ -90,7 +90,7 @@ void FuArea::DoExecute( SfxRequest& rReq )
 
             mpViewShell->GetViewFrame()->GetBindings().Invalidate( SidArray );
         }
-    }, pDlg);
+    });
 }
 
 void FuArea::Activate()

sd/source/ui/func/fuline.cxx

@@ -107,7 +107,7 @@ void FuLine::DoExecute( SfxRequest& rReq )
             mpViewShell->GetViewFrame()->GetBindings().Invalidate( SidArray );
         }
         mpViewShell->Cancel();
-    }, pDlg);
+    });
 }
 
 void FuLine::Activate()

sd/source/ui/func/futransf.cxx

@@ -152,7 +152,7 @@ void FuTransform::DoExecute( SfxRequest& rReq )
 
         mpViewShell->Invalidate(SID_RULER_OBJECT);
         mpViewShell->Cancel();
-    }, pDlg);
+    });
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

sw/source/uibase/app/docst.cxx

@@ -868,7 +868,7 @@ void SwDocShell::Edit(
 
             if (pRequest)
                 pRequest->Done();
-        }, pDlg);
+        });
     }
     else
     {

sw/source/uibase/shells/textsh1.cxx

@@ -210,7 +210,7 @@ void sw_CharDialog(SwWrtShell &rWrtSh, bool bUseDialog, sal_uInt16 nSlot, const
             {
                 sw_CharDialogResult(pDlg->GetOutputItemSet(), rWrtSh, pCoreSet, bSel, bSelectionPut, pRequest.get());
             }
-        }, pDlg);
+        });
     }
     else if (pArgs)
     {
@@ -1125,7 +1125,7 @@ void SwTextShell::Execute(SfxRequest &rReq)
 
                         sw_ParagraphDialogResult(pSet, rWrtSh, *pRequest, pPaM);
                     }
-                }, pDlg);
+                });
             }
         }
         break;

sw/source/uibase/shells/txtnum.cxx

@@ -237,7 +237,7 @@ void SwTextShell::ExecEnterNum(SfxRequest &rReq)
             }
             else if (RET_USER == nResult)
                 GetShell().DelNumRules();
-        }, pDlg);
+        });
     }
     break;