loplugin:sequentialassign in comphelper..cui

Change-Id: I1a08f3684b785e31535adcfb4220ded267a77c3b
Reviewed-on: https://gerrit.libreoffice.org/70643
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

comphelper/source/processfactory/processfactory.cxx

@@ -58,8 +58,7 @@ void setProcessServiceFactory(const Reference< XMultiServiceFactory >& xSMgr)
 
 Reference< XMultiServiceFactory > getProcessServiceFactory()
 {
-    Reference< XMultiServiceFactory> xReturn;
-    xReturn = localProcessFactory( xReturn, false );
+    Reference< XMultiServiceFactory> xReturn = localProcessFactory( xReturn, false );
     if ( !xReturn.is() )
     {
         throw DeploymentException( "null process service factory" );

cppcanvas/qa/unit/test.cxx

@@ -49,8 +49,7 @@ void CanvasTest::testComposite()
 
     // a huge canvas ...
     Size aSize (1, 1);
-    uno::Reference<rendering::XBitmap> xBitmap;
-    xBitmap = xCanvas->getDevice ()->createCompatibleAlphaBitmap(
+    uno::Reference<rendering::XBitmap> xBitmap = xCanvas->getDevice ()->createCompatibleAlphaBitmap(
                         vcl::unotools::integerSize2DFromSize( aSize ) );
     CPPUNIT_ASSERT( xBitmap.is() );
 

cppcanvas/source/mtfrenderer/textaction.cxx

@@ -2027,9 +2027,7 @@ namespace cppcanvas
 
                 for( const auto& rVCLPolyPolygon : aVCLPolyPolyVector )
                 {
-                    ::basegfx::B2DPolyPolygon aPolyPolygon;
-
-                    aPolyPolygon = rVCLPolyPolygon.getB2DPolyPolygon();
+                    ::basegfx::B2DPolyPolygon aPolyPolygon = rVCLPolyPolygon.getB2DPolyPolygon();
                     aPolyPolygon.transform( aMapModeTransform );
 
                     // append result to collecting polypoly

cui/source/customize/eventdlg.cxx

@@ -67,9 +67,7 @@ SvxEventConfigPage::SvxEventConfigPage(TabPageParent pParent, const SfxItemSet&
     m_xSaveInListBox->connect_changed( LINK( this, SvxEventConfigPage,
                 SelectHdl_Impl ) );
 
-    uno::Reference< frame::XGlobalEventBroadcaster > xSupplier;
-
-    xSupplier =
+    uno::Reference< frame::XGlobalEventBroadcaster > xSupplier =
         frame::theGlobalEventBroadcaster::get(::comphelper::getProcessComponentContext());
 
     m_xAppEvents = xSupplier->getEvents();

cui/source/dialogs/hldocntp.cxx

@@ -204,8 +204,7 @@ void SvxHyperlinkNewDocTp::FillDocumentList ()
             if ( pFilter )
             {
                 // insert doc-name and image
-                OUString aTitleName( aTitle );
-                aTitleName = aTitleName.replaceFirst( "~", "" );
+                OUString aTitleName = aTitle.replaceFirst( "~", "" );
 
                 sal_Int16 nPos = m_pLbDocTypes->InsertEntry ( aTitleName );
                 OUString aStrDefExt( pFilter->GetDefaultExtension () );

cui/source/dialogs/scriptdlg.cxx

@@ -822,8 +822,7 @@ void SvxScriptOrgDialog::createEntry(weld::TreeIter& rEntry)
         Sequence< sal_Int16 > outIndex;
         try
         {
-            Any aResult;
-            aResult = xInv->invoke( "Creatable", args, outIndex, outArgs );
+            Any aResult = xInv->invoke( "Creatable", args, outIndex, outArgs );
             Reference< browse::XBrowseNode > newNode( aResult, UNO_QUERY );
             aChildNode = newNode;
 
@@ -907,8 +906,7 @@ void SvxScriptOrgDialog::renameEntry(weld::TreeIter& rEntry)
         Sequence< sal_Int16 > outIndex;
         try
         {
-            Any aResult;
-            aResult = xInv->invoke( "Renamable", args, outIndex, outArgs );
+            Any aResult = xInv->invoke( "Renamable", args, outIndex, outArgs );
             Reference< browse::XBrowseNode > newNode( aResult, UNO_QUERY );
             aChildNode = newNode;
 
@@ -959,8 +957,7 @@ void SvxScriptOrgDialog::deleteEntry(weld::TreeIter& rEntry)
         Sequence< sal_Int16 > outIndex;
         try
         {
-            Any aResult;
-            aResult = xInv->invoke( "Deletable", args, outIndex, outArgs );
+            Any aResult = xInv->invoke( "Deletable", args, outIndex, outArgs );
             aResult >>= result; // or do we just assume true if no exception ?
         }
         catch( Exception const & )

cui/source/options/optaboutconfig.cxx

@@ -678,8 +678,7 @@ IMPL_LINK_NOARG( CuiAboutConfigTabPage, StandardHdl_Impl, Button*, void )
                     {
                         //create string sequence from comma separated string
                         //uno::Sequence< OUString > seqStr;
-                        std::vector< OUString > seqStr;
-                        seqStr = commaStringToSequence( sNewValue );
+                        std::vector< OUString > seqStr = commaStringToSequence( sNewValue );
 
                         //create appropriate sequence with same size as string sequence
                         uno::Sequence< sal_Int16 > seqShort( seqStr.size() );
@@ -692,8 +691,7 @@ IMPL_LINK_NOARG( CuiAboutConfigTabPage, StandardHdl_Impl, Button*, void )
                     }
                     else if( sPropertyType == "[]long" )
                     {
-                        std::vector< OUString > seqStrLong;
-                        seqStrLong = commaStringToSequence( sNewValue );
+                        std::vector< OUString > seqStrLong = commaStringToSequence( sNewValue );
 
                         uno::Sequence< sal_Int32 > seqLong( seqStrLong.size() );
                         for( size_t i = 0; i < seqStrLong.size(); ++i )
@@ -704,8 +702,7 @@ IMPL_LINK_NOARG( CuiAboutConfigTabPage, StandardHdl_Impl, Button*, void )
                     }
                     else if( sPropertyType == "[]hyper" )
                     {
-                        std::vector< OUString > seqStrHyper;
-                        seqStrHyper = commaStringToSequence( sNewValue );
+                        std::vector< OUString > seqStrHyper = commaStringToSequence( sNewValue );
                         uno::Sequence< sal_Int64 > seqHyper( seqStrHyper.size() );
                         for( size_t i = 0; i < seqStrHyper.size(); ++i )
                         {
@@ -715,8 +712,7 @@ IMPL_LINK_NOARG( CuiAboutConfigTabPage, StandardHdl_Impl, Button*, void )
                     }
                     else if( sPropertyType == "[]double" )
                     {
-                        std::vector< OUString > seqStrDoub;
-                        seqStrDoub = commaStringToSequence( sNewValue );
+                        std::vector< OUString > seqStrDoub = commaStringToSequence( sNewValue );
                         uno::Sequence< double > seqDoub( seqStrDoub.size() );
                         for( size_t i = 0; i < seqStrDoub.size(); ++i )
                         {
@@ -726,8 +722,7 @@ IMPL_LINK_NOARG( CuiAboutConfigTabPage, StandardHdl_Impl, Button*, void )
                     }
                     else if( sPropertyType == "[]float" )
                     {
-                        std::vector< OUString > seqStrFloat;
-                        seqStrFloat = commaStringToSequence( sNewValue );
+                        std::vector< OUString > seqStrFloat = commaStringToSequence( sNewValue );
                         uno::Sequence< sal_Int16 > seqFloat( seqStrFloat.size() );
                         for( size_t i = 0; i < seqStrFloat.size(); ++i )
                         {

cui/source/options/optlingu.cxx

@@ -1462,8 +1462,7 @@ IMPL_LINK(SvxLinguTabPage, ClickHdl_Impl, weld::Button&, rBtn, void)
             sal_Int32 nDics = aDics.getLength();
             if (nDicPos < nDics)
             {
-                uno::Reference< XDictionary > xDic;
-                xDic = aDics.getConstArray()[ nDicPos ];
+                uno::Reference< XDictionary > xDic = aDics.getConstArray()[ nDicPos ];
                 if (xDic.is())
                 {
                     SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create();
@@ -1488,8 +1487,7 @@ IMPL_LINK(SvxLinguTabPage, ClickHdl_Impl, weld::Button&, rBtn, void)
             sal_Int32 nDics = aDics.getLength();
             if (nDicPos < nDics)
             {
-                uno::Reference< XDictionary > xDic;
-                xDic = aDics.getConstArray()[ nDicPos ];
+                uno::Reference< XDictionary > xDic = aDics.getConstArray()[ nDicPos ];
                 if (xDic.is())
                 {
                     if (LinguMgr::GetIgnoreAllList() == xDic)

cui/source/options/optsave.cxx

@@ -408,8 +408,7 @@ void SvxSaveTabPage::Reset( const SfxItemSet* )
                 for(sal_Int32 n = 0; n < aDocTypeLB->GetEntryCount(); n++)
                 {
                     sal_IntPtr nData = reinterpret_cast<sal_IntPtr>(aDocTypeLB->GetEntryData(n));
-                    OUString sCommand;
-                    sCommand = "getSortedFilterList():module=%1:iflags=" +
+                    OUString sCommand = "getSortedFilterList():module=%1:iflags=" +
                                OUString::number(static_cast<int>(SfxFilterFlags::IMPORT|SfxFilterFlags::EXPORT)) +
                                ":eflags=" +
                                OUString::number(static_cast<int>(SfxFilterFlags::NOTINFILEDLG));