Kaydet (Commit) 72ec9cc3 authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:useuniqueptr in SdrCreateView

Change-Id: I41f3441593afa1884d5e8cda4126e97b545fd0a8
Reviewed-on: https://gerrit.libreoffice.org/53750Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 5175e38d
......@@ -22,6 +22,7 @@
#include <svx/svddrgv.hxx>
#include <svx/svxdllapi.h>
#include <memory>
class XLineAttrSetItem;
class XFillAttrSetItem;
......@@ -38,7 +39,7 @@ class SVX_DLLPUBLIC SdrCreateView : public SdrDragView
protected:
SdrObject* pCurrentCreate; // The currently being created object
SdrPageView* pCreatePV; // Here, the creation is started
ImplConnectMarkerOverlay* mpCoMaOverlay;
std::unique_ptr<ImplConnectMarkerOverlay> mpCoMaOverlay;
// for migrating stuff from XOR, use ImpSdrCreateViewExtraData ATM to not need to
// compile the apps all the time
......
......@@ -175,11 +175,7 @@ void ImpSdrCreateViewExtraData::HideOverlay()
void SdrCreateView::ImpClearConnectMarker()
{
if(mpCoMaOverlay)
{
delete mpCoMaOverlay;
mpCoMaOverlay = nullptr;
}
mpCoMaOverlay.reset();
}
void SdrCreateView::ImpClearVars()
......@@ -201,7 +197,6 @@ SdrCreateView::SdrCreateView(
SdrModel& rSdrModel,
OutputDevice* pOut)
: SdrDragView(rSdrModel, pOut),
mpCoMaOverlay(nullptr),
mpCreateViewExtraData(new ImpSdrCreateViewExtraData())
{
ImpClearVars();
......@@ -295,7 +290,7 @@ void SdrCreateView::SetConnectMarker(const SdrObjConnection& rCon)
if(!mpCoMaOverlay)
{
mpCoMaOverlay = new ImplConnectMarkerOverlay(*this, *pTargetObject);
mpCoMaOverlay.reset(new ImplConnectMarkerOverlay(*this, *pTargetObject));
}
}
else
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment