detect conditions where loop cannot logically end

Change-Id: I7e2ec1e09614510e6798ba8d5b9990c189a8dbb9

detect conditions where loop cannot logically end
Change-Id: I7e2ec1e09614510e6798ba8d5b9990c189a8dbb9
739adde5 · Caolán McNamara · 0792aef9 · 739adde5
Kaydet (Commit) 739adde5 authored Agu 25, 2014 tarafından Caolán McNamara
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

clippedlinerenderer.hxx include/basebmp/clippedlinerenderer.hxx +6 -0

No files found.
--- a/include/basebmp/clippedlinerenderer.hxx
+++ b/include/basebmp/clippedlinerenderer.hxx
@@ -269,6 +269,9 @@ void renderClippedLine( basegfx::B2IPoint             aPt1,

        if( bUseAlternateBresenham )
        {
+            if (rem < 0 && ady <= 0)
+                return; //break will never be hit under these circumstances
+
            while(true)
            {
                acc.set(color, rowIter);
@@ -347,6 +350,9 @@ void renderClippedLine( basegfx::B2IPoint             aPt1,

        if( bUseAlternateBresenham )
        {
+            if (rem < 0 && adx <= 0)
+                return; //break will never be hit under these circumstances
+
            while(true)
            {
                acc.set(color, colIter);