loplugin:useuniqueptr in DocShell_Impl

Change-Id: I171dbce9ad9790e887a6618812eadfb746dee42f
Reviewed-on: https://gerrit.libreoffice.org/52646Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

sc/source/ui/docshell/docsh3.cxx

@@ -451,10 +451,9 @@ SfxPrinter* ScDocShell::GetPrinter(bool bCreateIfNotExist)
 
 void ScDocShell::UpdateFontList()
 {
-    delete pImpl->pFontList;
     // pImpl->pFontList = new FontList( GetPrinter(), Application::GetDefaultDevice() );
-    pImpl->pFontList = new FontList(GetRefDevice(), nullptr);
-    SvxFontListItem aFontListItem( pImpl->pFontList, SID_ATTR_CHAR_FONTLIST );
+    pImpl->pFontList.reset(new FontList(GetRefDevice(), nullptr));
+    SvxFontListItem aFontListItem( pImpl->pFontList.get(), SID_ATTR_CHAR_FONTLIST );
     PutItem( aFontListItem );
 
     CalcOutputFactor();

sc/source/ui/docshell/docsh4.cxx

@@ -763,15 +763,14 @@ void ScDocShell::Execute( SfxRequest& rReq )
                         : sfx2::DocumentInserter::Mode::Merge};
                     // start file dialog asynchronous
                     pImpl->bIgnoreLostRedliningWarning = true;
-                    delete pImpl->pRequest;
-                    pImpl->pRequest = new SfxRequest( rReq );
-                    delete pImpl->pDocInserter;
+                    pImpl->pRequest.reset(new SfxRequest( rReq ));
+                    pImpl->pDocInserter.reset();
 
                     ScTabViewShell* pViewSh = ScTabViewShell::GetActiveViewShell();
                     vcl::Window* pParent = pViewSh ? pViewSh->GetDialogParent() : nullptr;
 
-                    pImpl->pDocInserter = new ::sfx2::DocumentInserter(pParent ? pParent->GetFrameWeld() : nullptr,
-                        ScDocShell::Factory().GetFactoryName(), mode );
+                    pImpl->pDocInserter.reset( new ::sfx2::DocumentInserter(pParent ? pParent->GetFrameWeld() : nullptr,
+                        ScDocShell::Factory().GetFactoryName(), mode ) );
                     pImpl->pDocInserter->StartExecuteModal( LINK( this, ScDocShell, DialogClosedHdl ) );
                     return ;
                 }
@@ -1990,7 +1989,7 @@ void ScDocShell::GetState( SfxItemSet &rSet )
                 break;
 
             case SID_ATTR_CHAR_FONTLIST:
-                rSet.Put( SvxFontListItem( pImpl->pFontList, nWhich ) );
+                rSet.Put( SvxFontListItem( pImpl->pFontList.get(), nWhich ) );
                 break;
 
             case SID_NOTEBOOKBAR:

sc/source/ui/docshell/docshimp.hxx

@@ -26,23 +26,14 @@
 struct DocShell_Impl
 {
     bool                    bIgnoreLostRedliningWarning;
-    FontList*               pFontList;
-    sfx2::DocumentInserter* pDocInserter;
-    SfxRequest*             pRequest;
+    std::unique_ptr<FontList>               pFontList;
+    std::unique_ptr<sfx2::DocumentInserter> pDocInserter;
+    std::unique_ptr<SfxRequest>             pRequest;
 
     DocShell_Impl() :
           bIgnoreLostRedliningWarning( false )
-        , pFontList( nullptr )
-        , pDocInserter( nullptr )
-        , pRequest( nullptr )
     {}
 
-    ~DocShell_Impl()
-    {
-        delete pFontList;
-        delete pDocInserter;
-        delete pRequest;
-    }
 };
 
 #endif