Kaydet (Commit) 74aeeb9a authored tarafından Bjoern Michaelsen's avatar Bjoern Michaelsen Kaydeden (comit) Björn Michaelsen

dont use SwClient/SwModify in unocore: ChartDataProvider

- and to the couragous person writing that comment:
  * yes, likely you should have come back to check if this was
    superfluous
  * no, you didnt (so far)

Change-Id: I56633aee4b49979b60417f88235e9393c0bc48c8
Reviewed-on: https://gerrit.libreoffice.org/54895Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarBjörn Michaelsen <bjoern.michaelsen@libreoffice.org>
üst 5f1ce0a7
...@@ -100,8 +100,7 @@ typedef cppu::WeakImplHelper ...@@ -100,8 +100,7 @@ typedef cppu::WeakImplHelper
SwChartDataProviderBaseClass; SwChartDataProviderBaseClass;
class SwChartDataProvider : class SwChartDataProvider :
public SwChartDataProviderBaseClass, public SwChartDataProviderBaseClass
public SwClient
{ {
// used to keep weak-references to all data-sequences of a single table // used to keep weak-references to all data-sequences of a single table
...@@ -142,10 +141,6 @@ class SwChartDataProvider : ...@@ -142,10 +141,6 @@ class SwChartDataProvider :
static OUString GetBrokenCellRangeForExport( const OUString &rCellRangeRepresentation ); static OUString GetBrokenCellRangeForExport( const OUString &rCellRangeRepresentation );
protected:
//SwClient
virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override;
public: public:
SwChartDataProvider( const SwDoc* pDoc ); SwChartDataProvider( const SwDoc* pDoc );
virtual ~SwChartDataProvider() override; virtual ~SwChartDataProvider() override;
......
...@@ -1455,12 +1455,6 @@ uno::Sequence< OUString > SAL_CALL SwChartDataProvider::getSupportedServiceNames ...@@ -1455,12 +1455,6 @@ uno::Sequence< OUString > SAL_CALL SwChartDataProvider::getSupportedServiceNames
return { "com.sun.star.chart2.data.DataProvider"}; return { "com.sun.star.chart2.data.DataProvider"};
} }
void SwChartDataProvider::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew)
{
// actually this function should be superfluous (need to check later)
ClientModify(this, pOld, pNew );
}
void SwChartDataProvider::AddDataSequence( const SwTable &rTable, uno::Reference< chart2::data::XDataSequence > const &rxDataSequence ) void SwChartDataProvider::AddDataSequence( const SwTable &rTable, uno::Reference< chart2::data::XDataSequence > const &rxDataSequence )
{ {
aDataSequences[ &rTable ].insert( rxDataSequence ); aDataSequences[ &rTable ].insert( rxDataSequence );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment