Kaydet (Commit) 757871e7 authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#704719 Dereference after null check

Change-Id: I99855ab0a79ea653177fba85089253b01b73b8c8
üst fb2bc8d9
......@@ -378,9 +378,9 @@ static sal_Bool lcl_IsEditableMatrix( ScDocument* pDoc, const ScRange& rRange )
return (aCell.meType == CELLTYPE_FORMULA && aCell.mpFormula->GetMatrixOrigin(aPos) && aPos == rRange.aStart);
}
static void lcl_UnLockComment( ScDrawView* pView, SdrPageView* pPV, SdrModel* pDrDoc, const Point& rPos, ScViewData* pViewData )
static void lcl_UnLockComment( ScDrawView* pView, const Point& rPos, ScViewData* pViewData )
{
if (!pView && !pPV && !pDrDoc && !pViewData)
if (!pView || !pViewData)
return;
ScDocument& rDoc = *pViewData->GetDocument();
......@@ -3216,7 +3216,7 @@ void ScGridWindow::SelectForContextMenu( const Point& rPosPixel, SCsCOL nCellX,
pDrawView->UnmarkAllObj();
// Unlock the Internal Layer in order to activate the context menu.
// re-lock in ScDrawView::MarkListHasChanged()
lcl_UnLockComment( pDrawView, pDrawView->GetSdrPageView(), pDrawView->GetModel(), aLogicPos ,pViewData);
lcl_UnLockComment( pDrawView, aLogicPos ,pViewData);
bHitDraw = pDrawView->MarkObj( aLogicPos );
// draw shell is activated in MarkListHasChanged
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment