loplugin:constparams in extensions,scripting,sdext

Change-Id: I3d47e144db17358bf6e2e5e3f4ad29de888c01b1
Reviewed-on: https://gerrit.libreoffice.org/40583Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

extensions/source/abpilot/datasourcehandling.cxx

@@ -55,7 +55,7 @@ namespace
 {
 
 /// Returns the URL of this object shell.
-OUString lcl_getOwnURL(SfxObjectShell* pObjectShell)
+OUString lcl_getOwnURL(SfxObjectShell const * pObjectShell)
 {
     OUString aRet;
 

extensions/source/dbpilots/controlwizard.cxx

@@ -630,7 +630,7 @@ namespace dbp
     }
 
 
-    void OControlWizard::commitControlSettings(OControlWizardSettings* _pSettings)
+    void OControlWizard::commitControlSettings(OControlWizardSettings const * _pSettings)
     {
         DBG_ASSERT(m_aContext.xObjectModel.is(), "OControlWizard::commitControlSettings: have no control model to work with!");
         if (!m_aContext.xObjectModel.is())

extensions/source/dbpilots/controlwizard.hxx

@@ -126,7 +126,7 @@ namespace dbp
         // with some common data extracted from the control model
         void initControlSettings(OControlWizardSettings* _pSettings);
         // commit the control-relevant settings
-        void commitControlSettings(OControlWizardSettings* _pSettings);
+        void commitControlSettings(OControlWizardSettings const * _pSettings);
 
         bool needDatasourceSelection();
 

extensions/source/propctrlr/usercontrol.cxx

@@ -141,7 +141,7 @@ namespace pcr
     }
 
 
-    double OFormatSampleControl::getPreviewValue(SvNumberFormatter* _pNF,sal_Int32 _nFormatKey)
+    double OFormatSampleControl::getPreviewValue(SvNumberFormatter const * _pNF, sal_Int32 _nFormatKey)
     {
         const SvNumberformat* pEntry = _pNF->GetEntry(_nFormatKey);
         DBG_ASSERT( pEntry, "OFormattedNumericControl::SetFormatDescription: invalid format key!" );

extensions/source/propctrlr/usercontrol.hxx

@@ -77,7 +77,7 @@ namespace pcr
         * \param _nFormatKey the format key
         * \return current date or time or the value 1234.56789
         */
-        static double getPreviewValue(SvNumberFormatter* _pNF,sal_Int32 _nFormatKey);
+        static double getPreviewValue(SvNumberFormatter const * _pNF, sal_Int32 _nFormatKey);
 
     private:
         static double getPreviewValue( const SvNumberformat& i_rEntry );

extensions/source/scanner/grid.cxx

@@ -57,7 +57,7 @@ class GridWindow : public vcl::Window
             rRenderContext.DrawBitmapEx(maPos - aOffset, rBitmapEx);
         }
 
-        bool isHit(vcl::Window& rWin, const Point& rPos)
+        bool isHit(vcl::Window const & rWin, const Point& rPos)
         {
             const Point aOffset(rWin.PixelToLogic(Point(mnOffX, mnOffY)));
             const tools::Rectangle aTarget(maPos - aOffset, maPos + aOffset);
@@ -111,7 +111,7 @@ class GridWindow : public vcl::Window
     void computeExtremes();
     static void computeChunk( double fMin, double fMax, double& fChunkOut, double& fMinChunkOut );
     void computeNew();
-    static double interpolate( double x, double* pNodeX, double* pNodeY, int nNodes );
+    static double interpolate( double x, double const * pNodeX, double const * pNodeY, int nNodes );
 
     virtual void MouseMove( const MouseEvent& ) override;
     virtual void MouseButtonDown( const MouseEvent& ) override;
@@ -414,8 +414,8 @@ void GridWindow::computeNew()
 
 double GridWindow::interpolate(
     double x,
-    double* pNodeX,
-    double* pNodeY,
+    double const * pNodeX,
+    double const * pNodeY,
     int nNodes )
 {
     // compute Lagrange interpolation

extensions/source/update/ui/updatecheckui.cxx

@@ -159,7 +159,7 @@ private:
     VclPtr<BubbleWindow> GetBubbleWindow();
     void            RemoveBubbleWindow( bool bRemoveIcon );
     void            AddMenuBarIcon( SystemWindow* pSysWin, bool bAddEventHdl );
-    Image           GetBubbleImage( OUString &rURL );
+    Image           GetBubbleImage( OUString const &rURL );
 
 public:
     explicit        UpdateCheckUI(const uno::Reference<uno::XComponentContext>&);
@@ -238,7 +238,7 @@ UpdateCheckUI::supportsService( OUString const & serviceName )
     return cppu::supportsService(this, serviceName);
 }
 
-Image UpdateCheckUI::GetBubbleImage( OUString &rURL )
+Image UpdateCheckUI::GetBubbleImage( OUString const &rURL )
 {
     Image aImage;
 

scripting/source/dlgprov/dlgevtatt.cxx

@@ -194,7 +194,7 @@ namespace dlgprov
             throw RuntimeException(); // more text info here please
         return it->second;
     }
-    Reference< XScriptEventsSupplier > DialogEventsAttacherImpl::getFakeVbaEventsSupplier( const Reference< XControl >& xControl, OUString& sControlName )
+    Reference< XScriptEventsSupplier > DialogEventsAttacherImpl::getFakeVbaEventsSupplier( const Reference< XControl >& xControl, OUString const & sControlName )
     {
         Reference< XScriptEventsSupplier > xEventsSupplier;
         Reference< XMultiComponentFactory > xSMgr( m_xContext->getServiceManager() );

scripting/source/dlgprov/dlgevtatt.hxx

@@ -54,7 +54,7 @@ namespace dlgprov
         css::uno::Reference< css::script::XEventAttacher > m_xEventAttacher;
         /// @throws css::uno::RuntimeException
         css::uno::Reference< css::script::XScriptListener > getScriptListenerForKey( const OUString& sScriptName );
-        css::uno::Reference< css::script::XScriptEventsSupplier > getFakeVbaEventsSupplier( const css::uno::Reference< css::awt::XControl>& xControl, OUString& sCodeName );
+        css::uno::Reference< css::script::XScriptEventsSupplier > getFakeVbaEventsSupplier( const css::uno::Reference< css::awt::XControl>& xControl, OUString const & sCodeName );
         void nestedAttachEvents( const css::uno::Sequence< css::uno::Reference< css::uno::XInterface > >& Objects, const css::uno::Any& Helper, OUString& sDialogCodeName );
         void attachEventsToControl( const css::uno::Reference< css::awt::XControl>& xControl, const css::uno::Reference< css::script::XScriptEventsSupplier >& events, const css::uno::Any& Helper  );
     public:

scripting/source/inc/util/MiscUtils.hxx

@@ -126,7 +126,7 @@ static css::uno::Reference< css::frame::XModel > tDocUrlToModel( const OUString&
 }
 
 
-static css::uno::Any getUCBProperty( ::ucbhelper::Content& content, OUString& prop )
+static css::uno::Any getUCBProperty( ::ucbhelper::Content& content, OUString const & prop )
 {
     css::uno::Any result;
     try

scripting/source/stringresource/stringresource.cxx

@@ -1701,7 +1701,7 @@ OUString implGetNameScemeForLocaleItem( const LocaleItem* pLocaleItem )
 }
 
 OUString StringResourcePersistenceImpl::implGetFileNameForLocaleItem
-    ( LocaleItem* pLocaleItem, const OUString& aNameBase )
+    ( LocaleItem const * pLocaleItem, const OUString& aNameBase )
 {
     OUString aFileName = aNameBase;
     if( aFileName.isEmpty() )
@@ -1712,7 +1712,7 @@ OUString StringResourcePersistenceImpl::implGetFileNameForLocaleItem
 }
 
 OUString StringResourcePersistenceImpl::implGetPathForLocaleItem
-    ( LocaleItem* pLocaleItem, const OUString& aNameBase,
+    ( LocaleItem const * pLocaleItem, const OUString& aNameBase,
       const OUString& aLocation, bool bDefaultFile )
 {
     OUString aFileName = implGetFileNameForLocaleItem( pLocaleItem, aNameBase );

scripting/source/stringresource/stringresource.hxx

@@ -223,8 +223,8 @@ protected:
     virtual void implLoadAllLocales() override;
 
     void implScanLocaleNames( const css::uno::Sequence< OUString >& aContentSeq );
-    static OUString implGetFileNameForLocaleItem( LocaleItem* pLocaleItem, const OUString& aNameBase );
-    static OUString implGetPathForLocaleItem( LocaleItem* pLocaleItem, const OUString& aNameBase,
+    static OUString implGetFileNameForLocaleItem( LocaleItem const * pLocaleItem, const OUString& aNameBase );
+    static OUString implGetPathForLocaleItem( LocaleItem const * pLocaleItem, const OUString& aNameBase,
         const OUString& aLocation, bool bDefaultFile=false );
 
     bool implReadPropertiesFile( LocaleItem* pLocaleItem,

sdext/source/minimizer/informationdialog.cxx

@@ -303,7 +303,7 @@ void InformationDialog::InitDialog()
 }
 
 
-InformationDialog::InformationDialog( const Reference< XComponentContext > &rxContext, Reference< XFrame >& rxFrame, const OUString& rSaveAsURL, bool& rbOpenNewDocument, sal_Int64 rSourceSize, sal_Int64 rDestSize, sal_Int64 rApproxSize ) :
+InformationDialog::InformationDialog( const Reference< XComponentContext > &rxContext, Reference< XFrame > const & rxFrame, const OUString& rSaveAsURL, bool& rbOpenNewDocument, sal_Int64 rSourceSize, sal_Int64 rDestSize, sal_Int64 rApproxSize ) :
     UnoDialog( rxContext, rxFrame ),
     ConfigurationAccess( rxContext ),
     mxActionListener( new OKActionListener( *this ) ),

sdext/source/minimizer/informationdialog.hxx

@@ -42,8 +42,8 @@ class InformationDialog : public UnoDialog, public ConfigurationAccess
 public:
 
     InformationDialog( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
-            css::uno::Reference< css::frame::XFrame >& rxFrame, const OUString& rSaveAsURL,
-                bool& bOpenNewDocument, sal_Int64 nSourceSize, sal_Int64 nDestSize, sal_Int64 nApproxDest );
+                       css::uno::Reference< css::frame::XFrame > const & rxFrame, const OUString& rSaveAsURL,
+                       bool& bOpenNewDocument, sal_Int64 nSourceSize, sal_Int64 nDestSize, sal_Int64 nApproxDest );
     ~InformationDialog();
 
     void                execute();

sdext/source/minimizer/optimizerdialog.cxx

@@ -192,7 +192,7 @@ void OptimizerDialog::UpdateConfiguration()
 }
 
 
-OptimizerDialog::OptimizerDialog( const Reference< XComponentContext > &rxContext, Reference< XFrame >& rxFrame, Reference< XDispatch > const & rxStatusDispatcher ) :
+OptimizerDialog::OptimizerDialog( const Reference< XComponentContext > &rxContext, Reference< XFrame > const & rxFrame, Reference< XDispatch > const & rxStatusDispatcher ) :
     UnoDialog( rxContext, rxFrame ),
     ConfigurationAccess( rxContext ),
     mnCurrentStep( 0 ),

sdext/source/minimizer/optimizerdialog.hxx

@@ -60,7 +60,7 @@ class OptimizerDialog : public UnoDialog, public ConfigurationAccess
 {
 public:
 
-    OptimizerDialog( const css::uno::Reference< css::uno::XComponentContext >& rxContext, css::uno::Reference< css::frame::XFrame >& rxFrame,
+    OptimizerDialog( const css::uno::Reference< css::uno::XComponentContext >& rxContext, css::uno::Reference< css::frame::XFrame > const & rxFrame,
         css::uno::Reference< css::frame::XDispatch > const & rxStatusDispatcher );
     ~OptimizerDialog();
 

sdext/source/minimizer/unodialog.cxx

@@ -38,7 +38,7 @@ using namespace ::com::sun::star::view;
 using namespace ::com::sun::star::frame;
 using namespace ::com::sun::star::beans;
 
-UnoDialog::UnoDialog( const Reference< XComponentContext > &rxContext, Reference< XFrame >& rxFrame ) :
+UnoDialog::UnoDialog( const Reference< XComponentContext > &rxContext, Reference< XFrame > const & rxFrame ) :
     mxContext( rxContext ),
     mxController( rxFrame->getController() ),
     mxDialogModel( mxContext->getServiceManager()->createInstanceWithContext(

sdext/source/minimizer/unodialog.hxx

@@ -53,7 +53,7 @@ class UnoDialog
 {
 public:
 
-    UnoDialog( const css::uno::Reference< css::uno::XComponentContext >& rxMSF, css::uno::Reference< css::frame::XFrame >& rxFrame );
+    UnoDialog( const css::uno::Reference< css::uno::XComponentContext >& rxMSF, css::uno::Reference< css::frame::XFrame > const & rxFrame );
     ~UnoDialog();
 
     void execute();