Kaydet (Commit) 771bb58c authored tarafından Jan Holesovsky's avatar Jan Holesovsky

editeng tiled editing: Don't overwrite bInSelection.

Setting bInSelection in MouseButtonUp() feels wrong, and against of its other
handling elsewhere.  Also it breaks the selection handling in the tiled
rendering case - on further redraw, selections may disappear.

But it has been so since the initial check-in of the OOo code, so I have no
idea what corner case I might break by deleting this, so let's guard the
behavior by isTiledReneding() for now.

Change-Id: I7f7b237f9f0f427e317266e05481bac439c3c8ad
üst 3f04bfef
...@@ -567,7 +567,15 @@ bool ImpEditEngine::MouseButtonUp( const MouseEvent& rMEvt, EditView* pView ) ...@@ -567,7 +567,15 @@ bool ImpEditEngine::MouseButtonUp( const MouseEvent& rMEvt, EditView* pView )
{ {
GetSelEngine().SetCurView( pView ); GetSelEngine().SetCurView( pView );
GetSelEngine().SelMouseButtonUp( rMEvt ); GetSelEngine().SelMouseButtonUp( rMEvt );
bInSelection = false;
// in the tiled rendering case, setting bInSelection here has unexpected
// consequences - further tiles painting removes the selection
// FIXME I believe resetting bInSelection should not be here even in the
// non-tiled-rendering case, but it has been here since 2000 (and before)
// so who knows what corner case it was supposed to solve back then
if (!pView->pImpEditView->isTiledRendering())
bInSelection = false;
// Special treatments // Special treatments
EditSelection aCurSel( pView->pImpEditView->GetEditSelection() ); EditSelection aCurSel( pView->pImpEditView->GetEditSelection() );
if ( !aCurSel.HasRange() ) if ( !aCurSel.HasRange() )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment