Kaydet (Commit) 791bb169 authored tarafından Takeshi Abe's avatar Takeshi Abe Kaydeden (comit) Noel Grandin

sc: Peel off a pimpl

Change-Id: I8797ccc165fb0a6060c6232babc299114411130a
Reviewed-on: https://gerrit.libreoffice.org/64707
Tested-by: Jenkins
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 7bf6d0d9
...@@ -11,13 +11,11 @@ ...@@ -11,13 +11,11 @@
#define SC_LISTENERQUERY_HXX #define SC_LISTENERQUERY_HXX
#include "address.hxx" #include "address.hxx"
#include "rangelst.hxx"
#include <svl/listener.hxx> #include <svl/listener.hxx>
#include <unordered_map> #include <unordered_map>
#include <vector> #include <vector>
#include <memory>
class ScRangeList;
namespace sc { namespace sc {
...@@ -51,8 +49,7 @@ private: ...@@ -51,8 +49,7 @@ private:
class QueryRange : public SvtListener::QueryBase class QueryRange : public SvtListener::QueryBase
{ {
struct Impl; ScRangeList maRanges;
std::unique_ptr<Impl> mpImpl;
QueryRange( const QueryRange& ) = delete; QueryRange( const QueryRange& ) = delete;
QueryRange& operator= ( const QueryRange& ) = delete; QueryRange& operator= ( const QueryRange& ) = delete;
......
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
#include <listenerquery.hxx> #include <listenerquery.hxx>
#include <listenerqueryids.hxx> #include <listenerqueryids.hxx>
#include <address.hxx> #include <address.hxx>
#include <rangelst.hxx>
namespace sc { namespace sc {
...@@ -68,14 +67,9 @@ const RefQueryFormulaGroup::TabsType& RefQueryFormulaGroup::getAllPositions() co ...@@ -68,14 +67,9 @@ const RefQueryFormulaGroup::TabsType& RefQueryFormulaGroup::getAllPositions() co
return maTabs; return maTabs;
} }
struct QueryRange::Impl
{
ScRangeList maRanges;
};
QueryRange::QueryRange() : QueryRange::QueryRange() :
SvtListener::QueryBase(SC_LISTENER_QUERY_FORMULA_GROUP_RANGE), SvtListener::QueryBase(SC_LISTENER_QUERY_FORMULA_GROUP_RANGE)
mpImpl(new Impl) {} {}
QueryRange::~QueryRange() QueryRange::~QueryRange()
{ {
...@@ -83,12 +77,12 @@ QueryRange::~QueryRange() ...@@ -83,12 +77,12 @@ QueryRange::~QueryRange()
void QueryRange::add( const ScRange& rRange ) void QueryRange::add( const ScRange& rRange )
{ {
mpImpl->maRanges.Join(rRange); maRanges.Join(rRange);
} }
void QueryRange::swapRanges( ScRangeList& rRanges ) void QueryRange::swapRanges( ScRangeList& rRanges )
{ {
mpImpl->maRanges.swap(rRanges); maRanges.swap(rRanges);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment