Kaydet (Commit) 7a7b346a authored tarafından Stephan Bergmann's avatar Stephan Bergmann

Properly assign objects to only those libraries that actually use them.

For that, moved aImplJavaUtf8TextEncodingData from tables.cxx to
textenc.cxx, as it shares code with aImplUTF8TextEncoding (but does
not drag lots of expensive data back into sal from sal_textenc).
üst ce3ffbae
...@@ -119,22 +119,13 @@ $(eval $(call gb_Library_add_exception_objects,sal,\ ...@@ -119,22 +119,13 @@ $(eval $(call gb_Library_add_exception_objects,sal,\
sal/rtl/source/ustrbuf \ sal/rtl/source/ustrbuf \
sal/rtl/source/ustring \ sal/rtl/source/ustring \
sal/rtl/source/uuid \ sal/rtl/source/uuid \
sal/textenc/convertsinglebytetobmpunicode \
sal/textenc/textenc \ sal/textenc/textenc \
)) ))
$(eval $(call gb_Library_add_cobjects,sal,\ $(eval $(call gb_Library_add_cobjects,sal,\
sal/osl/all/filepath \ sal/osl/all/filepath \
sal/textenc/context \ sal/textenc/context \
sal/textenc/convertbig5hkscs \
sal/textenc/converter \ sal/textenc/converter \
sal/textenc/converteuctw \
sal/textenc/convertgb18030 \
sal/textenc/convertiso2022cn \
sal/textenc/convertiso2022jp \
sal/textenc/convertiso2022kr \
sal/textenc/tcvtbyte \ sal/textenc/tcvtbyte \
sal/textenc/tcvtmb \
sal/textenc/tcvtutf7 \
sal/textenc/tcvtutf8 \ sal/textenc/tcvtutf8 \
sal/textenc/tenchelp \ sal/textenc/tenchelp \
sal/textenc/tencinfo \ sal/textenc/tencinfo \
......
...@@ -55,7 +55,6 @@ $(eval $(call gb_Library_add_cobjects,sal_textenc,\ ...@@ -55,7 +55,6 @@ $(eval $(call gb_Library_add_cobjects,sal_textenc,\
sal/textenc/tcvtbyte \ sal/textenc/tcvtbyte \
sal/textenc/tcvtmb \ sal/textenc/tcvtmb \
sal/textenc/tcvtutf7 \ sal/textenc/tcvtutf7 \
sal/textenc/tcvtutf8 \
sal/textenc/tenchelp \ sal/textenc/tenchelp \
sal/textenc/unichars \ sal/textenc/unichars \
)) ))
......
...@@ -133,6 +133,7 @@ extern "C" SAL_DLLPUBLIC_EXPORT ImplTextEncodingData const * ...@@ -133,6 +133,7 @@ extern "C" SAL_DLLPUBLIC_EXPORT ImplTextEncodingData const *
assert( assert(
nEncoding != RTL_TEXTENCODING_ASCII_US && nEncoding != RTL_TEXTENCODING_ASCII_US &&
nEncoding != RTL_TEXTENCODING_ISO_8859_1 && nEncoding != RTL_TEXTENCODING_ISO_8859_1 &&
nEncoding != RTL_TEXTENCODING_JAVA_UTF8 &&
nEncoding != RTL_TEXTENCODING_MS_1252 && nEncoding != RTL_TEXTENCODING_MS_1252 &&
nEncoding != RTL_TEXTENCODING_UTF8); nEncoding != RTL_TEXTENCODING_UTF8);
// handled by Impl_getTextEncodingData // handled by Impl_getTextEncodingData
...@@ -227,7 +228,7 @@ extern "C" SAL_DLLPUBLIC_EXPORT ImplTextEncodingData const * ...@@ -227,7 +228,7 @@ extern "C" SAL_DLLPUBLIC_EXPORT ImplTextEncodingData const *
&aImplTis620TextEncodingData, /* TIS_620 */ &aImplTis620TextEncodingData, /* TIS_620 */
&aImplKoi8UTextEncodingData, /* KOI8_U */ &aImplKoi8UTextEncodingData, /* KOI8_U */
&aImplIsciiDevanagariTextEncodingData, /* ISCII_DEVANAGARI */ &aImplIsciiDevanagariTextEncodingData, /* ISCII_DEVANAGARI */
&aImplJavaUtf8TextEncodingData, /* JAVA_UTF8 */ NULL, /* JAVA_UTF8, see above */
&adobeStandardEncodingData, /* ADOBE_STANDARD */ &adobeStandardEncodingData, /* ADOBE_STANDARD */
&adobeSymbolEncodingData, /* ADOBE_SYMBOL */ &adobeSymbolEncodingData, /* ADOBE_SYMBOL */
&aImplPT154TextEncodingData }; /* PT154 */ &aImplPT154TextEncodingData }; /* PT154 */
......
...@@ -25,10 +25,6 @@ ...@@ -25,10 +25,6 @@
* *
************************************************************************/ ************************************************************************/
#ifndef INCLUDED_RTL_TEXTENC_CONTEXT_H
#include "context.h"
#endif
/* Unicode Encodings */ /* Unicode Encodings */
static ImplTextEncodingData const aImplUTF7TextEncodingData static ImplTextEncodingData const aImplUTF7TextEncodingData
...@@ -53,26 +49,3 @@ static ImplTextEncodingData const aImplUTF7TextEncodingData ...@@ -53,26 +49,3 @@ static ImplTextEncodingData const aImplUTF7TextEncodingData
| RTL_TEXTENCODING_INFO_MULTIBYTE | RTL_TEXTENCODING_INFO_MULTIBYTE
| RTL_TEXTENCODING_INFO_MIME }; | RTL_TEXTENCODING_INFO_MIME };
/* SCRIPT_UNICODE, pc code page 850 */ /* SCRIPT_UNICODE, pc code page 850 */
static char aImplJavaUtf8TextConverterTag;
/* The value of this tag is irrelevant. Only its address != NULL is used to
distinguish between RTL_TEXTENCODING_UTF8 and
RTL_TEXTENCODING_JAVA_UTF8. */
static ImplTextEncodingData const aImplJavaUtf8TextEncodingData
= { { &aImplJavaUtf8TextConverterTag,
&ImplConvertUtf8ToUnicode,
&ImplConvertUnicodeToUtf8,
&ImplCreateUtf8ToUnicodeContext,
&ImplDestroyContext,
&ImplResetUtf8ToUnicodeContext,
&ImplCreateUnicodeToUtf8Context,
&ImplDestroyContext,
&ImplResetUnicodeToUtf8Context },
1,
3,
1,
0,
NULL,
NULL,
RTL_TEXTENCODING_INFO_UNICODE | RTL_TEXTENCODING_INFO_MULTIBYTE };
...@@ -339,6 +339,29 @@ static ImplTextEncodingData const aImplUTF8TextEncodingData ...@@ -339,6 +339,29 @@ static ImplTextEncodingData const aImplUTF8TextEncodingData
| RTL_TEXTENCODING_INFO_MIME }; | RTL_TEXTENCODING_INFO_MIME };
/* SCRIPT_UNICODE, pc code page 850 */ /* SCRIPT_UNICODE, pc code page 850 */
static char aImplJavaUtf8TextConverterTag;
/* The value of this tag is irrelevant. Only its address != NULL is used to
distinguish between RTL_TEXTENCODING_UTF8 and
RTL_TEXTENCODING_JAVA_UTF8. */
static ImplTextEncodingData const aImplJavaUtf8TextEncodingData
= { { &aImplJavaUtf8TextConverterTag,
&ImplConvertUtf8ToUnicode,
&ImplConvertUnicodeToUtf8,
&ImplCreateUtf8ToUnicodeContext,
&ImplDestroyContext,
&ImplResetUtf8ToUnicodeContext,
&ImplCreateUnicodeToUtf8Context,
&ImplDestroyContext,
&ImplResetUnicodeToUtf8Context },
1,
3,
1,
0,
NULL,
NULL,
RTL_TEXTENCODING_INFO_UNICODE | RTL_TEXTENCODING_INFO_MULTIBYTE };
namespace { namespace {
#if defined IOS #if defined IOS
...@@ -408,6 +431,8 @@ Impl_getTextEncodingData(rtl_TextEncoding nEncoding) SAL_THROW_EXTERN_C() ...@@ -408,6 +431,8 @@ Impl_getTextEncodingData(rtl_TextEncoding nEncoding) SAL_THROW_EXTERN_C()
return &aImplMS1252TextEncodingData; break; return &aImplMS1252TextEncodingData; break;
case RTL_TEXTENCODING_UTF8: case RTL_TEXTENCODING_UTF8:
return &aImplUTF8TextEncodingData; break; return &aImplUTF8TextEncodingData; break;
case RTL_TEXTENCODING_JAVA_UTF8:
return &aImplJavaUtf8TextEncodingData; break;
case RTL_TEXTENCODING_ISO_8859_1: case RTL_TEXTENCODING_ISO_8859_1:
return &aImplISO88591TextEncodingData; break; return &aImplISO88591TextEncodingData; break;
default: default:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment