Kaydet (Commit) 806dfdaf authored tarafından Mike Kaganski's avatar Mike Kaganski

Use 'with open(file) as f:' to avoid 'ResourceWarning: unclosed file'

Removes 220 warnings from build log (at least under Windows).
Requires Python 2.5+

Change-Id: I06b18b14a08f2c27528fcb009faddff081ffd54e
Reviewed-on: https://gerrit.libreoffice.org/29172Reviewed-by: 's avatarMichael Stahl <mstahl@redhat.com>
Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
üst 769f6405
...@@ -18,11 +18,17 @@ scp2componentcondition = sys.argv[2] ...@@ -18,11 +18,17 @@ scp2componentcondition = sys.argv[2]
scp2libtemplate = sys.argv[3] scp2libtemplate = sys.argv[3]
scp2exetemplate = sys.argv[4] scp2exetemplate = sys.argv[4]
scp2jartemplate = sys.argv[5] scp2jartemplate = sys.argv[5]
sdklibs = open(sys.argv[6]).readline().split() # use 'with open(file) as f:' to avoid 'ResourceWarning: unclosed file'
libs = open(sys.argv[7]).readline().split() with open(sys.argv[6]) as f:
exes = open(sys.argv[8]).readline().split() sdklibs = f.readline().split()
jars = open(sys.argv[9]).readline().split() with open(sys.argv[7]) as f:
pkgs = open(sys.argv[10]).readline().split() libs = f.readline().split()
with open(sys.argv[8]) as f:
exes = f.readline().split()
with open(sys.argv[9]) as f:
jars = f.readline().split()
with open(sys.argv[10]) as f:
pkgs = f.readline().split()
if len(scp2componentcondition) > 0: if len(scp2componentcondition) > 0:
scp2componentcondition = "," + scp2componentcondition scp2componentcondition = "," + scp2componentcondition
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment