loplugin:constfields in tools

Change-Id: I83499cfb49f7abdbf0629c60167d09a1352571ee
Reviewed-on: https://gerrit.libreoffice.org/60987
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/tools/multisel.hxx

@@ -77,16 +77,16 @@ class SAL_WARN_UNUSED TOOLS_DLLPUBLIC StringRangeEnumerator
 {
     struct Range
     {
-        sal_Int32   nFirst;
-        sal_Int32   nLast;
+        sal_Int32 const   nFirst;
+        sal_Int32 const   nLast;
 
         Range( sal_Int32 i_nFirst, sal_Int32 i_nLast ) : nFirst( i_nFirst ), nLast( i_nLast ) {}
     };
     std::vector< StringRangeEnumerator::Range >            maSequence;
     sal_Int32                                              mnCount;
-    sal_Int32                                              mnMin;
-    sal_Int32                                              mnMax;
-    sal_Int32                                              mnOffset;
+    sal_Int32 const                                        mnMin;
+    sal_Int32 const                                        mnMax;
+    sal_Int32 const                                        mnOffset;
     bool                                                   mbValidInput;
 
     bool setRange( const OUString& i_rNewRange );

include/tools/stream.hxx

@@ -100,7 +100,7 @@ enum SvLockBytesStatFlag { SVSTATFLAG_DEFAULT };
 class TOOLS_DLLPUBLIC SvLockBytes: public virtual SvRefBase
 {
     SvStream * m_pStream;
-    bool m_bOwner;
+    bool const m_bOwner;
     bool m_bSync;
 
 protected:

include/tools/vcompat.hxx

@@ -38,7 +38,7 @@ class TOOLS_DLLPUBLIC VersionCompat
     SvStream*       mpRWStm;
     sal_uInt32      mnCompatPos;
     sal_uInt32      mnTotalSize;
-    StreamMode   mnStmMode;
+    StreamMode const mnStmMode;
     sal_uInt16      mnVersion;
 
                     VersionCompat( const VersionCompat& ) = delete;

include/tools/zcodec.hxx

@@ -40,11 +40,11 @@ class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ZCodec
     bool            mbStatus;
     bool            mbFinish;
     sal_uInt8*      mpInBuf;
-    size_t          mnInBufSize;
+    size_t const    mnInBufSize;
     size_t          mnInToRead;
     SvStream*       mpOStm;
     sal_uInt8*      mpOutBuf;
-    size_t          mnOutBufSize;
+    size_t const    mnOutBufSize;
 
     sal_uInt32      mnCRC;
     int             mnCompressLevel;

tools/source/fsys/urlobj.cxx

@@ -290,14 +290,14 @@ struct INetURLObject::SchemeInfo
 {
     sal_Char const * m_pScheme;
     sal_Char const * m_pPrefix;
-    bool m_bAuthority;
-    bool m_bUser;
-    bool m_bAuth;
-    bool m_bPassword;
-    bool m_bHost;
-    bool m_bPort;
-    bool m_bHierarchical;
-    bool m_bQuery;
+    bool const m_bAuthority;
+    bool const m_bUser;
+    bool const m_bAuth;
+    bool const m_bPassword;
+    bool const m_bHost;
+    bool const m_bPort;
+    bool const m_bHierarchical;
+    bool const m_bQuery;
 };
 
 struct INetURLObject::PrefixInfo
@@ -306,8 +306,8 @@ struct INetURLObject::PrefixInfo
 
     sal_Char const * m_pPrefix;
     sal_Char const * m_pTranslatedPrefix;
-    INetProtocol m_eScheme;
-    Kind m_eKind;
+    INetProtocol const m_eScheme;
+    Kind const m_eKind;
 };
 
 // static

tools/source/inet/inetmime.cxx

@@ -309,12 +309,12 @@ void appendISO88591(OUStringBuffer & rText, sal_Char const * pBegin,
 
 struct Parameter
 {
-    OString m_aAttribute;
-    OString m_aCharset;
-    OString m_aLanguage;
-    OString m_aValue;
-    sal_uInt32 m_nSection;
-    bool m_bExtended;
+    OString const m_aAttribute;
+    OString const m_aCharset;
+    OString const m_aLanguage;
+    OString const m_aValue;
+    sal_uInt32 const m_nSection;
+    bool const m_bExtended;
 
     bool operator<(const Parameter& rhs) const // is used by std::list<Parameter>::sort
     {
@@ -800,7 +800,7 @@ bool equalIgnoreCase(const sal_Char * pBegin1,
 struct EncodingEntry
 {
     sal_Char const * m_aName;
-    rtl_TextEncoding m_eEncoding;
+    rtl_TextEncoding const m_eEncoding;
 };
 
 // The source for the following table is <ftp://ftp.iana.org/in-notes/iana/

tools/source/reversemap/bestreversemap.cxx

@@ -15,7 +15,7 @@
 
 struct Encoder
 {
-    rtl_UnicodeToTextConverter m_aConverter;
+    rtl_UnicodeToTextConverter const m_aConverter;
     bool m_bCapable;
     const char *m_pEncoding;
     Encoder(rtl_TextEncoding nEncoding, const char *pEncoding)

tools/source/xml/XmlWriter.cxx

@@ -39,7 +39,7 @@ struct XmlWriterImpl
     {
     }
 
-    SvStream* mpStream;
+    SvStream* const mpStream;
     xmlTextWriterPtr mpWriter;
 };