Kaydet (Commit) 84f4b842 authored tarafından Samuel Mehrbrodt's avatar Samuel Mehrbrodt Kaydeden (comit) Caolán McNamara

Better approach for fdo#40077: Characters cropped in GTK-Combobox

Now using gtk_widget_size_request() to get the native size.
I reverted the earlier change (border_width etc. ignored)

Change-Id: I0d89a2df5186bd27cbb77c8b0f2cc7b1fb247005
Reviewed-on: https://gerrit.libreoffice.org/6478Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst dc6c7e84
...@@ -219,7 +219,6 @@ static void NWPaintOneEditBox( SalX11Screen nScreen, GdkDrawable * gdkDrawable, ...@@ -219,7 +219,6 @@ static void NWPaintOneEditBox( SalX11Screen nScreen, GdkDrawable * gdkDrawable,
ControlState nState, const ImplControlValue& aValue, ControlState nState, const ImplControlValue& aValue,
const OUString& rCaption ); const OUString& rCaption );
//---
static Rectangle NWGetSpinButtonRect( SalX11Screen nScreen, ControlType nType, ControlPart nPart, Rectangle aAreaRect, ControlState nState, static Rectangle NWGetSpinButtonRect( SalX11Screen nScreen, ControlType nType, ControlPart nPart, Rectangle aAreaRect, ControlState nState,
const ImplControlValue& aValue, const OUString& rCaption ); const ImplControlValue& aValue, const OUString& rCaption );
...@@ -1147,7 +1146,7 @@ sal_Bool GtkSalGraphics::getNativeControlRegion( ControlType nType, ...@@ -1147,7 +1146,7 @@ sal_Bool GtkSalGraphics::getNativeControlRegion( ControlType nType,
rNativeContentRegion = aIndicatorRect; rNativeContentRegion = aIndicatorRect;
returnVal = sal_True; returnVal = sal_True;
} }
if( (nType == CTRL_EDITBOX || nType == CTRL_SPINBOX) && nPart == PART_ENTIRE_CONTROL ) if( (nType == CTRL_EDITBOX || nType == CTRL_SPINBOX || nType == CTRL_COMBOBOX) && nPart == PART_ENTIRE_CONTROL )
{ {
NWEnsureGTKEditBox( m_nXScreen ); NWEnsureGTKEditBox( m_nXScreen );
GtkWidget* widget = gWidgetData[m_nXScreen].gEditBoxWidget; GtkWidget* widget = gWidgetData[m_nXScreen].gEditBoxWidget;
...@@ -2442,8 +2441,6 @@ static Rectangle NWGetSpinButtonRect( SalX11Screen nScreen, ...@@ -2442,8 +2441,6 @@ static Rectangle NWGetSpinButtonRect( SalX11Screen nScreen,
return( buttonRect ); return( buttonRect );
} }
//---
static void NWPaintOneSpinButton( SalX11Screen nScreen, static void NWPaintOneSpinButton( SalX11Screen nScreen,
GdkPixmap* pixmap, GdkPixmap* pixmap,
ControlType nType, ControlType nType,
...@@ -2609,7 +2606,7 @@ static Rectangle NWGetComboBoxButtonRect( SalX11Screen nScreen, ...@@ -2609,7 +2606,7 @@ static Rectangle NWGetComboBoxButtonRect( SalX11Screen nScreen,
gint adjust_x = GTK_CONTAINER(gWidgetData[nScreen].gComboWidget)->border_width + gint adjust_x = GTK_CONTAINER(gWidgetData[nScreen].gComboWidget)->border_width +
nFocusWidth + nFocusWidth +
nFocusPad; nFocusPad;
gint adjust_y = gWidgetData[nScreen].gComboWidget->style->ythickness; gint adjust_y = adjust_x + gWidgetData[nScreen].gComboWidget->style->ythickness;
adjust_x += gWidgetData[nScreen].gComboWidget->style->xthickness; adjust_x += gWidgetData[nScreen].gComboWidget->style->xthickness;
aButtonRect.SetSize( Size( aAreaRect.GetWidth() - nButtonWidth - 2 * adjust_x, aButtonRect.SetSize( Size( aAreaRect.GetWidth() - nButtonWidth - 2 * adjust_x,
aAreaRect.GetHeight() - 2 * adjust_y ) ); aAreaRect.GetHeight() - 2 * adjust_y ) );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment