avoid out of bounds access

Change-Id: I4c7ddf2fcabc231b7250306b4a9255fab1a9ef7c

avoid out of bounds access
Change-Id: I4c7ddf2fcabc231b7250306b4a9255fab1a9ef7c
893298e7 · Markus Mohrhard · ad21f8ec · 893298e7
Kaydet (Commit) 893298e7 authored Tem 31, 2017 tarafından Markus Mohrhard
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

RemoteFilesDialog.cxx fpicker/source/office/RemoteFilesDialog.cxx +3 -2

No files found.
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -529,9 +529,10 @@ int RemoteFilesDialog::GetSelectedServicePos()
    if( m_aServices.empty() )
        return -1;

-    while( nPos < ( int )m_aServices.size() )
+    int nServices = static_cast<int>(m_aServices.size());
+    while( nPos < nServices )
    {
-        while( m_aServices[nPos]->IsLocal() )
+        while( (nPos < nServices) && m_aServices[nPos]->IsLocal() )
            nPos++;
        i++;
        if( i == nSelected )